From 7e5000cf5292f92a1e8efdaf352b4f52d59f9ecb Mon Sep 17 00:00:00 2001 From: jacobshandling <61553566+jacobshandling@users.noreply.github.com> Date: Fri, 13 Dec 2024 10:40:58 -0800 Subject: [PATCH] UI - Redirect on invalid URL parameter to `/software/add/fleet-maintained/:id` (#24637) ## #24636 Redirect when NaN "foobar" provided as software id in url: https://github.com/user-attachments/assets/e1b0ce3d-f494-447c-a452-285f0e6758af - [x] Changes file added for user-visible changes in `changes/`, - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Jacob Shandling --- changes/24636-UI-redirect-for-invalid-url-param | 1 + .../FleetMaintainedAppDetailsPage.tsx | 3 +++ 2 files changed, 4 insertions(+) create mode 100644 changes/24636-UI-redirect-for-invalid-url-param diff --git a/changes/24636-UI-redirect-for-invalid-url-param b/changes/24636-UI-redirect-for-invalid-url-param new file mode 100644 index 0000000000..6bd50ab9ab --- /dev/null +++ b/changes/24636-UI-redirect-for-invalid-url-param @@ -0,0 +1 @@ +* Redirect when user provides an invalid URL param for fleet-maintained software id diff --git a/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/FleetMaintainedAppDetailsPage/FleetMaintainedAppDetailsPage.tsx b/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/FleetMaintainedAppDetailsPage/FleetMaintainedAppDetailsPage.tsx index 5d88909a07..657851e5b2 100644 --- a/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/FleetMaintainedAppDetailsPage/FleetMaintainedAppDetailsPage.tsx +++ b/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/FleetMaintainedAppDetailsPage/FleetMaintainedAppDetailsPage.tsx @@ -98,6 +98,9 @@ const FleetMaintainedAppDetailsPage = ({ }: IFleetMaintainedAppDetailsPageProps) => { const teamId = location.query.team_id; const appId = parseInt(routeParams.id, 10); + if (isNaN(appId)) { + router.push(PATHS.SOFTWARE_ADD_FLEET_MAINTAINED); + } const { renderFlash } = useContext(NotificationContext); const { isPremiumTier } = useContext(AppContext);