Elgato_dark/fleet
1
0
Fork 0
mirror of https://github.com/fleetdm/fleet synced 2026-05-23 00:49:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 106

vulnerabilities.current_instance_checks=no is now an alias for vulnerabilities.disable_schedule=true (#18184)

Browse source 
#16661 
vulnerabilities.current_instance_checks=no is now an alias for
vulnerabilities.disable_schedule=true

PR for doc changes: https://github.com/fleetdm/fleet/pull/18186

# Checklist for submitter

- [x] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [ ] Added/updated tests
- [x] Manual QA for all new/changed functionality
This commit is contained in:
Victor Lyuboslavsky 2024-04-15 12:10:52 -05:00 committed by GitHub
parent 2da3ac368d
commit 7785aa5070
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changes/16661-current-instance-checks Normal file
View file

@ -0,0 +1 @@
vulnerabilities.current_instance_checks=no is now an alias for vulnerabilities.disable_schedule=true

4
cmd/fleet/cron.go
View file

@ -77,10 +77,6 @@ func cronVulnerabilities(
if config == nil {
return errors.New("nil configuration")
}
if config.CurrentInstanceChecks == "no" || config.CurrentInstanceChecks == "0" {
level.Info(logger).Log("msg", "host not configured to check for vulnerabilities")
return nil
}
level.Info(logger).Log("periodicity", config.Periodicity)

13
cmd/fleet/serve.go
View file

@ -713,15 +713,22 @@ the way that the Fleet server works.
initFatal(err, "failed to register stats schedule")
}
if !config.Vulnerabilities.DisableSchedule {
vulnerabilityScheduleDisabled := false
if config.Vulnerabilities.DisableSchedule {
vulnerabilityScheduleDisabled = true
level.Info(logger).Log("msg", "vulnerabilities schedule disabled via vulnerabilities.disable_schedule")
}
if config.Vulnerabilities.CurrentInstanceChecks == "no" || config.Vulnerabilities.CurrentInstanceChecks == "0" {
level.Info(logger).Log("msg", "vulnerabilities schedule disabled via vulnerabilities.current_instance_checks")
vulnerabilityScheduleDisabled = true
}
if !vulnerabilityScheduleDisabled {
// vuln processing by default is run by internal cron mechanism
if err := cronSchedules.StartCronSchedule(func() (fleet.CronSchedule, error) {
return newVulnerabilitiesSchedule(ctx, instanceID, ds, logger, &config.Vulnerabilities)
}); err != nil {
initFatal(err, "failed to register vulnerabilities schedule")
}
} else {
level.Info(logger).Log("msg", "vulnerabilities schedule disabled")
}
if err := cronSchedules.StartCronSchedule(func() (fleet.CronSchedule, error) {