From 744a72324756a8b0669299c4fb28e0bcf2490deb Mon Sep 17 00:00:00 2001 From: Scott Gress Date: Thu, 25 Sep 2025 12:21:49 -0500 Subject: [PATCH] Fix ace editor cursor issues on chromeos (#33478) **Related issue:** Resolves #30691 # Details This PR fixes an issue where the cursor in the SQL editor is positioned incorrectly on ChromeOS and Windows. Also fixed an incorrect style declaration that was preventing keywords from being bolded. Before: image After: image # Checklist for submitter If some of the following don't apply, delete the relevant line. - [X] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. ## Testing - [X] QA'd all new/changed functionality manually Tested on Chrome, Firefox, Safari and Microsoft Edge (where appropriate) on MacOS, Linux and Windows. Note that the specified padding does not render on ChromeOS or Windows (it doesn't in production right now either). --- changes/30691-fix-ace-editor-cursor | 1 + frontend/components/SQLEditor/_styles.scss | 2 +- frontend/components/SQLEditor/theme.css | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) create mode 100644 changes/30691-fix-ace-editor-cursor diff --git a/changes/30691-fix-ace-editor-cursor b/changes/30691-fix-ace-editor-cursor new file mode 100644 index 0000000000..89e184a970 --- /dev/null +++ b/changes/30691-fix-ace-editor-cursor @@ -0,0 +1 @@ +- Fixes an issue on ChromeOS and Windows where the cursor in the SQL editor is misaligned. diff --git a/frontend/components/SQLEditor/_styles.scss b/frontend/components/SQLEditor/_styles.scss index fd8f02d6fc..6ef7b19062 100644 --- a/frontend/components/SQLEditor/_styles.scss +++ b/frontend/components/SQLEditor/_styles.scss @@ -28,7 +28,7 @@ } } - .ace_content { + .ace_scroller { padding-left: 4px; } diff --git a/frontend/components/SQLEditor/theme.css b/frontend/components/SQLEditor/theme.css index 426bda0694..8545082165 100644 --- a/frontend/components/SQLEditor/theme.css +++ b/frontend/components/SQLEditor/theme.css @@ -89,7 +89,7 @@ .ace-fleet .ace_keyword { color: #ae6ddf; - font-weight: $bold; + font-weight: 700; } .ace-fleet .ace_osquery-token {