From 6eebbd2aecabd989caec72c39584bf63c9b90a9a Mon Sep 17 00:00:00 2001
From: Zach Wasserman <zach@fleetdm.com>
Date: Thu, 22 Jul 2021 11:14:26 -0700
Subject: [PATCH] Add retries to flaky enroll secret test (#1445)

There seems to be something flaky about downloading the enroll secret in
the test. I can't reproduce any issue with doing so locally, so I'm
adding a retry to get this to quiet down in CI.
---
 cypress/integration/all/app/hosts.spec.ts | 68 +++++++++++++----------
 1 file changed, 38 insertions(+), 30 deletions(-)

diff --git a/cypress/integration/all/app/hosts.spec.ts b/cypress/integration/all/app/hosts.spec.ts
index e17e71baeb..ead1cbedef 100644
--- a/cypress/integration/all/app/hosts.spec.ts
+++ b/cypress/integration/all/app/hosts.spec.ts
@@ -11,36 +11,44 @@ describe("Hosts page", () => {
     cy.stopDockerHost();
   });
 
-  it("Add new host", () => {
-    cy.visit("/");
-
-    cy.contains("button", /add new host/i).click();
-
-    cy.contains("a", /download/i)
-      .first()
-      .click();
-
-    cy.get('a[href*="showSecret"]').click();
-
-    // Assert enroll secret downloaded matches the one displayed
-    cy.readFile(path.join(Cypress.config("downloadsFolder"), "secret.txt"), {
-      timeout: 5000,
-    }).then((contents) => {
-      cy.get("input[disabled]").should("have.value", contents);
-    });
-
-    // Wait until the host becomes available (usually immediate in local
-    // testing, but may vary by environment).
-    cy.waitUntil(
-      () => {
-        cy.visit("/");
-        return Cypress.$('button[title="Online"]').length > 0;
+  it(
+    "Add new host",
+    {
+      retries: {
+        runMode: 2,
       },
-      { timeout: 30000, interval: 1000 }
-    );
+    },
+    () => {
+      cy.visit("/");
 
-    // Go to host details page
-    cy.get('button[title="Online"]').click();
-    cy.get("span.status").contains("online");
-  });
+      cy.contains("button", /add new host/i).click();
+
+      cy.contains("a", /download/i)
+        .first()
+        .click();
+
+      cy.get('a[href*="showSecret"]').click();
+
+      // Assert enroll secret downloaded matches the one displayed
+      cy.readFile(path.join(Cypress.config("downloadsFolder"), "secret.txt"), {
+        timeout: 5000,
+      }).then((contents) => {
+        cy.get("input[disabled]").should("have.value", contents);
+      });
+
+      // Wait until the host becomes available (usually immediate in local
+      // testing, but may vary by environment).
+      cy.waitUntil(
+        () => {
+          cy.visit("/");
+          return Cypress.$('button[title="Online"]').length > 0;
+        },
+        { timeout: 30000, interval: 1000 }
+      );
+
+      // Go to host details page
+      cy.get('button[title="Online"]').click();
+      cy.get("span.status").contains("online");
+    }
+  );
 });