From 6a70f2ab7854937fd6abc00b58079f069728d665 Mon Sep 17 00:00:00 2001
From: RachelElysia <71795832+RachelElysia@users.noreply.github.com>
Date: Thu, 11 Apr 2024 16:28:42 -0400
Subject: [PATCH] [unreleased bug] Fleet UI: Fix UI to expect null values
instead of undefined values for orbit and fleetd versions (#18208)
---
frontend/interfaces/host.ts | 4 ++--
.../pages/hosts/details/cards/HostSummary/HostSummary.tsx | 5 +++--
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/frontend/interfaces/host.ts b/frontend/interfaces/host.ts
index 2e92da6490..623bf0b66f 100644
--- a/frontend/interfaces/host.ts
+++ b/frontend/interfaces/host.ts
@@ -269,8 +269,8 @@ export interface IHost {
uuid: string;
platform: string;
osquery_version: string;
- orbit_version?: string;
- fleet_desktop_version?: string;
+ orbit_version: string | null;
+ fleet_desktop_version: string | null;
os_version: string;
build: string;
platform_like: string; // TODO: replace with more specific union type
diff --git a/frontend/pages/hosts/details/cards/HostSummary/HostSummary.tsx b/frontend/pages/hosts/details/cards/HostSummary/HostSummary.tsx
index f52c8b06bc..97a513198b 100644
--- a/frontend/pages/hosts/details/cards/HostSummary/HostSummary.tsx
+++ b/frontend/pages/hosts/details/cards/HostSummary/HostSummary.tsx
@@ -321,7 +321,7 @@ const HostSummary = ({
if (platform === "chrome") {
return ;
}
- if (summaryData.orbit_version) {
+ if (summaryData.orbit_version !== DEFAULT_EMPTY_CELL_VALUE) {
return (
Orbit: {summaryData.orbit_version}
- {summaryData.fleet_desktop_version && (
+ {summaryData.fleet_desktop_version !==
+ DEFAULT_EMPTY_CELL_VALUE && (
<>
Fleet Desktop: {summaryData.fleet_desktop_version}