mirror of
https://github.com/fleetdm/fleet
synced 2026-05-05 22:39:17 +00:00
Fix path for Controls top nav link (#33556)
<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #33222 # Details This PR fixes an issue where clicking "Controls" in the top nav doesn't go to the expected page when the current page is a Controls tab like "Scripts". The expected page is the default "Controls" page, i.e. the first tab (currently the "OS Settings" tab). # Checklist for submitter If some of the following don't apply, delete the relevant line. - [X] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. ## Testing - [ ] Added/updated automated tests I made a pass at this but it requires either the router or mocking the `<Link>/<ContextLink>` components which seems like overkill for this. - [X] QA'd all new/changed functionality manually 
This commit is contained in:
parent
99d31dd4ad
commit
62799c3ad4
2 changed files with 2 additions and 0 deletions
1
changes/33222-fix-controls-top-nav
Normal file
1
changes/33222-fix-controls-top-nav
Normal file
|
|
@ -0,0 +1 @@
|
|||
- Fixed issue where "Controls" link in the top nav didn't always go to the default controls page.
|
||||
|
|
@ -67,6 +67,7 @@ export default (
|
|||
pathname: PATHS.CONTROLS,
|
||||
},
|
||||
exclude: !isMaintainerOrAdmin,
|
||||
alwaysToPathname: true,
|
||||
withParams: { type: "query", names: ["team_id"] },
|
||||
},
|
||||
{
|
||||
|
|
|
|||
Loading…
Reference in a new issue