Elgato_dark/fleet
1
0
Fork 0
mirror of https://github.com/fleetdm/fleet synced 2026-05-24 01:18:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 84

Match no results tooltip text to Figma (#14516)

Browse source 
## Addresses [Reed's comment in
Slack](https://fleetdm.slack.com/archives/C01EZVBHFHU/p1697144038116529)
<img width="655" alt="Screenshot 2023-10-12 at 2 45 51 PM"
src="https://github.com/fleetdm/fleet/assets/61553566/b48621a6-092a-4623-91f5-03d7749733f6">
<img width="655" alt="Screenshot 2023-10-12 at 2 47 47 PM"
src="https://github.com/fleetdm/fleet/assets/61553566/e7844ecd-a2d8-4122-ae3e-35a4a62f45c6">
<img width="655" alt="Screenshot 2023-10-12 at 2 47 32 PM"
src="https://github.com/fleetdm/fleet/assets/61553566/2932fe4a-6b5c-4d09-9a96-1d88c39808e9">

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
This commit is contained in:
Jacob Shandling 2023-10-12 14:52:27 -07:00 committed by GitHub
parent 2a8e69b964
commit 600fb401d6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
frontend/pages/queries/details/components/NoResults/NoResults.tsx
View file

@ -66,14 +66,18 @@ const NoResults = ({
// In order of empty page priority
if (disabledCaching) {
const tipContent = () => {
// TODO - change to JSX with refactor tooltipwrapper merge
if (disabledCachingGlobally) {
return "The following setting prevents saving this query's results in Fleet:<ul><li>Query reports are globally disabled in organization settings.</li></ul>";
return `<div>The following setting prevents saving this query's results in Fleet:</div>\
<div>&nbsp; • Query reports are globally disabled in organization settings.</div>`;
}
if (discardDataEnabled) {
return "The following setting prevents saving this query's results in Fleet:<ul><li>This query has Discard data enabled.</li></ul>";
return `<div>The following setting prevents saving this query's results in Fleet:</div>\
<div>&nbsp; • This query has <b>Discard data</b> enabled.</div>`;
}
if (!loggingSnapshot) {
return "The following setting prevents saving this query's results in Fleet:<ul><li>The logging setting for this query is not Snapshot.</li></ul>";
return `<div>The following setting prevents saving this query's results in Fleet:</div>\
<div>&nbsp; • The logging setting for this query is not <b>Snapshot</b>.</div>`;
}
return "Unknown";
};

9
frontend/pages/queries/details/components/NoResults/_styles.scss Normal file
View file

@ -0,0 +1,9 @@
.no-results {
.component__tooltip-wrapper {
&__tip-text {
display: flex;
flex-direction: column;
gap: $pad-xsmall;
}
}
}