From 5e647660bbfb0c7c8b9e54de709f2201338d7357 Mon Sep 17 00:00:00 2001
From: Luke Heath <luke@fleetdm.com>
Date: Wed, 23 Mar 2022 15:45:19 -0500
Subject: [PATCH] Filter out device users if no email is present (#4773)

---
 frontend/pages/hosts/DeviceUserPage/DeviceUserPage.tsx   | 8 ++++++--
 frontend/pages/hosts/HostDetailsPage/HostDetailsPage.tsx | 8 ++++++--
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/frontend/pages/hosts/DeviceUserPage/DeviceUserPage.tsx b/frontend/pages/hosts/DeviceUserPage/DeviceUserPage.tsx
index 779a15e18d..1d840fc271 100644
--- a/frontend/pages/hosts/DeviceUserPage/DeviceUserPage.tsx
+++ b/frontend/pages/hosts/DeviceUserPage/DeviceUserPage.tsx
@@ -69,7 +69,11 @@ const DeviceUserPage = ({
       refetchOnReconnect: false,
       refetchOnWindowFocus: false,
       retry: false,
-      select: (data: IDeviceMappingResponse) => data.device_mapping,
+      select: (data: IDeviceMappingResponse) =>
+        data.device_mapping &&
+        data.device_mapping.filter(
+          (deviceUser) => deviceUser.email && deviceUser.email.length
+        ),
     }
   );
 
@@ -298,7 +302,7 @@ const DeviceUserPage = ({
             ) : (
               <span className={`${baseClass}__device-mapping`}>
                 <span
-                  className="device-user"
+                  className="device-user-list"
                   data-tip
                   data-for="device-user-tooltip"
                 >
diff --git a/frontend/pages/hosts/HostDetailsPage/HostDetailsPage.tsx b/frontend/pages/hosts/HostDetailsPage/HostDetailsPage.tsx
index 5a682a61bb..9c14ce51c6 100644
--- a/frontend/pages/hosts/HostDetailsPage/HostDetailsPage.tsx
+++ b/frontend/pages/hosts/HostDetailsPage/HostDetailsPage.tsx
@@ -211,7 +211,11 @@ const HostDetailsPage = ({
       refetchOnReconnect: false,
       refetchOnWindowFocus: false,
       retry: false,
-      select: (data: IDeviceMappingResponse) => data.device_mapping,
+      select: (data: IDeviceMappingResponse) =>
+        data.device_mapping &&
+        data.device_mapping.filter(
+          (deviceUser) => deviceUser.email && deviceUser.email.length
+        ),
     }
   );
 
@@ -1027,7 +1031,7 @@ const HostDetailsPage = ({
             ) : (
               <span className={`${baseClass}__device-mapping`}>
                 <span
-                  className="device-user"
+                  className="device-user-list"
                   data-tip
                   data-for="device-user-tooltip"
                 >