From 5d35b467d8f314beb27ce53162092dee0d2d590d Mon Sep 17 00:00:00 2001 From: Zach Wasserman Date: Mon, 12 Sep 2022 08:35:26 -0700 Subject: [PATCH] Remove errors tooltips from Fleet Desktop menu (#7678) Now that these errors are available in log files, we think this adds more confusion for end users. --- orbit/changes/remove-desktop-errors-tooltip | 1 + orbit/cmd/desktop/desktop.go | 7 +------ 2 files changed, 2 insertions(+), 6 deletions(-) create mode 100644 orbit/changes/remove-desktop-errors-tooltip diff --git a/orbit/changes/remove-desktop-errors-tooltip b/orbit/changes/remove-desktop-errors-tooltip new file mode 100644 index 0000000000..307ca4190f --- /dev/null +++ b/orbit/changes/remove-desktop-errors-tooltip @@ -0,0 +1 @@ +* Stop rendering errors as tooltips in Fleet Desktop. Errors can now be found in the Fleet Desktop logs. diff --git a/orbit/cmd/desktop/desktop.go b/orbit/cmd/desktop/desktop.go index b670430ed8..e75908a02d 100644 --- a/orbit/cmd/desktop/desktop.go +++ b/orbit/cmd/desktop/desktop.go @@ -49,7 +49,7 @@ func main() { log.Info().Msg("ready") systray.SetTemplateIcon(icoBytes, icoBytes) - systray.SetTooltip("Fleet Device Management Menu.") + systray.SetTooltip("Fleet Desktop") // Add a disabled menu item with the current version versionItem := systray.AddMenuItem(fmt.Sprintf("Fleet Desktop v%s", version), "") @@ -88,13 +88,10 @@ func main() { if err == nil || errors.Is(err, service.ErrMissingLicense) { myDeviceItem.SetTitle("My device") myDeviceItem.Enable() - myDeviceItem.SetTooltip("") transparencyItem.Enable() return } - // To ease troubleshooting we set the tooltip as the error. - myDeviceItem.SetTooltip(err.Error()) log.Error().Err(err).Msg("get device URL") <-ticker.C @@ -120,8 +117,6 @@ func main() { myDeviceItem.SetTitle("My device") continue default: - // To ease troubleshooting we set the tooltip as the error. - myDeviceItem.SetTooltip(err.Error()) log.Error().Err(err).Msg("get device URL") continue }