Elgato_dark/fleet
1
0
Fork 0
mirror of https://github.com/fleetdm/fleet synced 2026-05-24 01:18:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 84

Remove errors tooltips from Fleet Desktop menu (#7678)

Browse source 
Now that these errors are available in log files, we think this adds
more confusion for end users.
This commit is contained in:
Zach Wasserman 2022-09-12 08:35:26 -07:00 committed by GitHub
parent eb06ef8049
commit 5d35b467d8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
orbit/changes/remove-desktop-errors-tooltip Normal file
View file

@ -0,0 +1 @@
* Stop rendering errors as tooltips in Fleet Desktop. Errors can now be found in the Fleet Desktop logs.

7
orbit/cmd/desktop/desktop.go
View file

@ -49,7 +49,7 @@ func main() {
log.Info().Msg("ready")
systray.SetTemplateIcon(icoBytes, icoBytes)
systray.SetTooltip("Fleet Device Management Menu.")
systray.SetTooltip("Fleet Desktop")
// Add a disabled menu item with the current version
versionItem := systray.AddMenuItem(fmt.Sprintf("Fleet Desktop v%s", version), "")
@ -88,13 +88,10 @@ func main() {
if err == nil || errors.Is(err, service.ErrMissingLicense) {
myDeviceItem.SetTitle("My device")
myDeviceItem.Enable()
myDeviceItem.SetTooltip("")
transparencyItem.Enable()
return
}
// To ease troubleshooting we set the tooltip as the error.
myDeviceItem.SetTooltip(err.Error())
log.Error().Err(err).Msg("get device URL")
<-ticker.C
@ -120,8 +117,6 @@ func main() {
myDeviceItem.SetTitle("My device")
continue
default:
// To ease troubleshooting we set the tooltip as the error.
myDeviceItem.SetTooltip(err.Error())
log.Error().Err(err).Msg("get device URL")
continue
}