diff --git a/changes/23541-fileversion-fallback b/changes/23541-fileversion-fallback new file mode 100644 index 0000000000..b9ec9f22ad --- /dev/null +++ b/changes/23541-fileversion-fallback @@ -0,0 +1 @@ +* Added fallback to FileVersion on EXE installers when FileVersion is set but ProductVersion isn't to allow more custom packages to be uploaded diff --git a/pkg/file/pe.go b/pkg/file/pe.go index 4516b5a25e..0f5f7eb61c 100644 --- a/pkg/file/pe.go +++ b/pkg/file/pe.go @@ -72,6 +72,8 @@ func ExtractPEMetadata(tfr *fleet.TempFileReader) (*InstallerMetadata, error) { } if productVersion != "" { version = productVersion + } else if strings.TrimSpace(e["FileVersion"]) != "" { + version = strings.TrimSpace(e["FileVersion"]) } } if name == "" && sfxName != "" {