Elgato_dark/fleet
1
0
Fork 0
mirror of https://github.com/fleetdm/fleet synced 2026-05-24 01:18:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 59

Homepage - Hiding policy if neither passing or failing (#2708)

Browse source 
* not display policy if neither passing nor failing

* removed log
This commit is contained in:
Martavis Parker 2021-10-27 15:38:34 -07:00 committed by GitHub
parent b877c4244c
commit 58b33942a4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 33 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

53
frontend/pages/Homepage/cards/WelcomeHost/WelcomeHost.tsx
View file

@ -33,6 +33,7 @@ const WelcomeHost = (): JSX.Element => {
const [refetchStartTime, setRefetchStartTime] = useState<number | null>(null);
const [currentPolicyShown, setCurrentPolicyShown] = useState<IHostPolicy>();
const [showPolicyModal, setShowPolicyModal] = useState<boolean>(false);
const [isPoliciesEmpty, setIsPoliciesEmpty] = useState<boolean>(false);
const [
showRefetchLoadingSpinner,
setShowRefetchLoadingSpinner,
@ -50,6 +51,12 @@ const WelcomeHost = (): JSX.Element => {
select: (data: IHostResponse) => data.host,
onSuccess: (returnedHost) => {
setShowRefetchLoadingSpinner(returnedHost.refetch_requested);
const anyPassingOrFailingPolicy = returnedHost?.policies?.find(
(p) => p.response === "passing" || p.response === "failing"
);
setIsPoliciesEmpty(typeof anyPassingOrFailingPolicy === "undefined");
if (returnedHost.refetch_requested) {
// Code duplicated from HostDetailsPage. See comments there.
if (!refetchStartTime) {
@ -90,7 +97,7 @@ const WelcomeHost = (): JSX.Element => {
}
},
onError: (error) => {
console.log(error);
console.error(error);
dispatch(
renderFlash("error", `Unable to load host. Please try again.`)
);
@ -108,7 +115,7 @@ const WelcomeHost = (): JSX.Element => {
setTimeout(() => fullyReloadHost(), 1000);
});
} catch (error) {
console.log(error);
console.error(error);
dispatch(renderFlash("error", `Host "${host.hostname}" refetch error`));
setShowRefetchLoadingSpinner(false);
}
@ -164,7 +171,7 @@ const WelcomeHost = (): JSX.Element => {
);
}
if (host && !host.policies) {
if (isPoliciesEmpty) {
return (
<div className={baseClass}>
<div className={`${baseClass}__error`}>
@ -216,23 +223,29 @@ const WelcomeHost = (): JSX.Element => {
</p>
</div>
<div className={`${baseClass}__policies`}>
{host.policies?.slice(0, 10).map((p) => (
<div className="policy-block">
<div className="info">
<img
alt={p.response}
src={p.response === "passing" ? IconPassed : IconError}
/>
{p.query_name}
</div>
<Button
variant="text-icon"
onClick={() => handlePolicyModal(p.id)}
>
<img alt="" src={IconChevron} />
</Button>
</div>
))}
{host.policies?.slice(0, 10).map((p) => {
if (p.response) {
return (
<div className="policy-block">
<div className="info">
<img
alt={p.response}
src={p.response === "passing" ? IconPassed : IconError}
/>
{p.query_name}
</div>
<Button
variant="text-icon"
onClick={() => handlePolicyModal(p.id)}
>
<img alt="" src={IconChevron} />
</Button>
</div>
);
}
return null;
})}
{host.policies?.length > 10 && (
<Link to={PATHS.HOST_DETAILS(host)} className="external-link">
Go to Host details to see all checks