diff --git a/changes/issue-2630-error-empty-state-activity-feed b/changes/issue-2630-error-empty-state-activity-feed new file mode 100644 index 0000000000..8e07e1b767 --- /dev/null +++ b/changes/issue-2630-error-empty-state-activity-feed @@ -0,0 +1 @@ +* Cleaner error and empty state of activity feed \ No newline at end of file diff --git a/cypress/integration/all/app/labelflow.spec.ts b/cypress/integration/all/app/labelflow.spec.ts index f7ab6a3ecb..5d767d62d1 100644 --- a/cypress/integration/all/app/labelflow.spec.ts +++ b/cypress/integration/all/app/labelflow.spec.ts @@ -60,6 +60,7 @@ describe( cy.visit("/hosts/manage"); + cy.wait(3000); // eslint-disable-line cypress/no-unnecessary-waiting cy.findByText(/show all usernames/i).click(); // delete custom label diff --git a/cypress/integration/all/app/queryflow.spec.ts b/cypress/integration/all/app/queryflow.spec.ts index a49a67b40b..6f114ef414 100644 --- a/cypress/integration/all/app/queryflow.spec.ts +++ b/cypress/integration/all/app/queryflow.spec.ts @@ -38,6 +38,7 @@ describe( cy.findByText(/back to queries/i).should("exist"); cy.visit("/queries/manage"); + cy.wait(3000); // eslint-disable-line cypress/no-unnecessary-waiting cy.findByText(/query all/i).click(); cy.wait(2000); // eslint-disable-line cypress/no-unnecessary-waiting diff --git a/frontend/pages/Homepage/cards/ActivityFeed/ActivityFeed.tsx b/frontend/pages/Homepage/cards/ActivityFeed/ActivityFeed.tsx index d8fe323c78..6bcd36aedd 100644 --- a/frontend/pages/Homepage/cards/ActivityFeed/ActivityFeed.tsx +++ b/frontend/pages/Homepage/cards/ActivityFeed/ActivityFeed.tsx @@ -139,20 +139,24 @@ const ActivityFeed = (): JSX.Element => { const renderError = () => { return (
- error icon - Something’s gone wrong. -

Refresh the page or log in again.

-

- If this keeps happening, please{" "} - - file an issue - open new tab - -

+
+ + error icon + Something's gone wrong. + + Refresh the page or log in again. + + If this keeps happening, please  + + file an issue + open new tab + + +
); }; diff --git a/frontend/pages/Homepage/cards/ActivityFeed/_styles.scss b/frontend/pages/Homepage/cards/ActivityFeed/_styles.scss index 9660dadeb7..042e00b261 100644 --- a/frontend/pages/Homepage/cards/ActivityFeed/_styles.scss +++ b/frontend/pages/Homepage/cards/ActivityFeed/_styles.scss @@ -86,26 +86,59 @@ text-align: center; } - &__error { - display: inline-block; + &__no-activities { + font-size: $x-small; + p { + margin-top: 0; + } + } - b { - font-size: 16px; + &__error { + display: flex; + flex-direction: column; + align-items: center; + margin: $pad-xlarge 0; + + #error-icon { + height: 12px; + width: 12px; + margin-right: 8px; + } + + #new-tab-icon { + height: 12px; + width: 12px; + margin-left: 6px; } a { - img { - height: 12px; - width: 12px; - padding-left: $pad-small; - } + font-size: $x-small; + color: $core-vibrant-blue; + font-weight: $bold; + text-decoration: none; } - .error-icon { - transform: translateY(2px); - height: 16px; - width: 16px; - padding-right: $pad-small; + &__inner { + display: flex; + flex-direction: row; + } + + .info { + &__header { + display: block; + color: $core-fleet-black; + font-weight: $bold; + font-size: $x-small; + text-align: left; + } + &__data { + display: block; + color: $core-fleet-black; + font-weight: normal; + font-size: $x-small; + text-align: left; + margin-top: 10px; + } } } }