Elgato_dark/fleet
1
0
Fork 0
mirror of https://github.com/fleetdm/fleet synced 2026-05-24 09:28:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 30

Detect the NOPERM error to mean redis cluster is disabled (#5058)

Browse source
This commit is contained in:
Martin Angers 2022-04-11 16:17:30 -04:00 committed by GitHub
parent a8d7b5478b
commit 5483adc26b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changes/issue-5048-detect-noperm-redis-standalone Normal file
View file

@ -0,0 +1 @@
* Support Redis in standalone mode when CLUSTER commands are disabled via ACL.

3
server/datastore/redis/redis.go
View file

@ -336,7 +336,8 @@ func newCluster(conf PoolConfig) (*redisc.Cluster, error) {
}
func isClusterDisabled(err error) bool {
return strings.Contains(err.Error(), "ERR This instance has cluster support disabled")
return strings.Contains(err.Error(), "ERR This instance has cluster support disabled") ||
strings.Contains(err.Error(), "NOPERM this user has no permissions to run the 'cluster' command")
}
// On GCP Memorystore the CLUSTER command is entirely unavailable and fails with