Upload Cypress recordings/screenshots on E2E failure (#3341)

.github/workflows/test.yml

@@ -78,13 +78,23 @@ jobs:
         make
 
     - name: Run E2E Tests
+      id: e2e
       run: |
         .github/scripts/check-infra-dependencies.sh all
         make e2e-reset-db
         make e2e-serve-${{ matrix.fleet-tier }} &
         sleep 3
         make e2e-setup
-        yarn cypress run --config-file cypress-${{ matrix.fleet-tier }}.json --config video=false
+        yarn cypress run --config-file cypress-${{ matrix.fleet-tier }}.json
+
+    - name: Upload artifacts
+      if: failure()
+      uses: actions/upload-artifact@v2
+      with:
+        name: cypress
+        path: |
+          cypress/screenshots/
+          cypress/videos/
 
 
   test-js:

cypress-free.json

@@ -5,5 +5,6 @@
   "retries": {
     "runMode": 1,
     "openMode": 0
-  }
+  },
+  "videoUploadOnPasses": false
 }

cypress-premium.json

@@ -5,5 +5,6 @@
   "retries": {
     "runMode": 1,
     "openMode": 0
-  }
+  },
+  "videoUploadOnPasses": false
 }

cypress.json

@@ -6,6 +6,6 @@
   "retries": {
     "runMode": 1,
     "openMode": 0
-  }
+  },
+  "videoUploadOnPasses": false
 }
-