mirror of
https://github.com/fleetdm/fleet
synced 2026-05-24 01:18:42 +00:00
E2E testing: Cypress e2e tests for RBAC (#1096)
* Add e2e test for dual-role team maintainer/observer * Refine tests for global admin role
This commit is contained in:
gillespi314
GitHub
parent
1d3b624be2
commit
40b756e46e
2 changed files with 161 additions and 6 deletions
|
|
@ -5,6 +5,8 @@ if (Cypress.env("FLEET_TIER") === "basic") {
|
|||
cy.login();
|
||||
cy.seedBasic();
|
||||
cy.setupSMTP();
|
||||
cy.seedQueries();
|
||||
cy.addDockerHost();
|
||||
cy.logout();
|
||||
});
|
||||
|
||||
|
|
@ -18,8 +20,7 @@ if (Cypress.env("FLEET_TIER") === "basic") {
|
|||
// On the hosts page, they should…
|
||||
|
||||
// See the “Teams” column in the Hosts table
|
||||
// cy.findByRole("columnheader", { name: "Team" });
|
||||
// ^^TODO this test depends on seeding hosts because the table is not displayed if there are no hosts
|
||||
cy.get("thead").contains(/team/i).should("exist");
|
||||
|
||||
// See and select the “Add new host” button
|
||||
cy.contains("button", /add new host/i).click();
|
||||
|
|
@ -35,9 +36,9 @@ if (Cypress.env("FLEET_TIER") === "basic") {
|
|||
|
||||
// On the Host details page, they should…
|
||||
// See the “Team” information below the hostname
|
||||
// cy.visit("/hosts/2");
|
||||
// cy.visit("/hosts/1");
|
||||
// cy.findByText(/team/i).next().contains("Apples");
|
||||
// ^^TODO this test depends on seeding hosts
|
||||
// ^^TODO this test depends on seeding hosts and assigning hosts to teams
|
||||
|
||||
// On the Queries - new / edit / run page, they should…
|
||||
// See the “Teams” section in the Select target picker. This picker is summoned when the “Select targets” field is selected.
|
||||
|
|
|
|||
|
|
@ -4,17 +4,171 @@ if (Cypress.env("FLEET_TIER") === "basic") {
|
|||
cy.setup();
|
||||
cy.login();
|
||||
cy.seedBasic();
|
||||
cy.seedQueries();
|
||||
cy.addDockerHost();
|
||||
cy.logout();
|
||||
});
|
||||
|
||||
it("Can perform the appropriate actions", () => {
|
||||
it("Can perform the appropriate team observer actions", () => {
|
||||
cy.login("marco@organization.com", "user123#");
|
||||
cy.visit("/");
|
||||
|
||||
// Ensure page is loaded
|
||||
cy.contains("All hosts");
|
||||
|
||||
// TODO write the test!
|
||||
// On the Hosts page, they should…
|
||||
|
||||
// See hosts
|
||||
// cy.findByText(/kinda empty in here/i).should("not.exist");
|
||||
// ^^TODO hosts table is not rendering because we need new forEach script/command for admin to assign team after the host is added
|
||||
|
||||
// See the “Teams” column in the Hosts table
|
||||
// cy.get("thead").contains(/team/i).should("exist");
|
||||
|
||||
// NOT see the “Packs” and “Settings” navigation items
|
||||
cy.findByText(/packs/i).should("not.exist");
|
||||
cy.findByText(/settings/i).should("not.exist");
|
||||
|
||||
// NOT see and select "add new label"
|
||||
cy.findByRole("button", { name: /new label/i }).should("not.exist");
|
||||
|
||||
// On the Host details page, they should…
|
||||
|
||||
// See the “Team” information below the hostname
|
||||
// cy.visit("/hosts/1");
|
||||
// cy.findByText(/team/i).next().contains("Apples");
|
||||
// ^^TODO need new forEach script/command for admin to assign team after the host is added
|
||||
|
||||
// NOT see and select the “Delete” button
|
||||
// cy.findByText(/delete/i).should("not.exist");
|
||||
// ^^ TODO this is restriction only applies to hosts where they are not a maintainer
|
||||
|
||||
// NOT see and select the “Query” button
|
||||
// cy.findByText(/query/i).should("not.exist");
|
||||
// ^^ TODO this is restriction only applies to hosts where they are not a maintainer
|
||||
|
||||
// On the Queries manage page, they should…
|
||||
cy.visit("/queries/manage");
|
||||
cy.findByText(/no queries available/i).should("not.exist");
|
||||
|
||||
// See and select the “Show query” button in the right side panel if the saved query has `observer_can_run` set to `false`. This button appears after the user selects a query in the Queries table.
|
||||
// See and select the “Run query” button in the right side panel if the saved query has `observer_can_run` set to `true`. This button appears after the user selects a query in the Queries table.
|
||||
// ^^TODO confirm if these distinctions apply to dual-role user like Marco
|
||||
|
||||
// NOT see the “Observers can run” column in the Queries table
|
||||
// cy.findByText(/observers can run/i).should("not.exist");
|
||||
// ^^TODO confirm this does not apply to dual-role user like Marco
|
||||
|
||||
// NOT see and select the “Create new query” button
|
||||
// cy.findByText(/create new query/i).should("not.exist");
|
||||
// ^^TODO confirm this does not apply to dual-role user like Marco
|
||||
|
||||
// NOT see the “SQL” and “Packs” sections in the right side bar. These sections appear after the user selects a query in the Queries table.
|
||||
// cy.get(".secondary-side-panel-container").within(() => {
|
||||
// cy.findByText(/sql/i).should("not.exist");
|
||||
// cy.findByText(/packs/i).should("not.exist");
|
||||
// });
|
||||
// ^^TODO confirm this does not apply to dual-role user like Marco
|
||||
|
||||
// On the Query details page they should…
|
||||
cy.visit("/queries/1");
|
||||
|
||||
// See the “Show SQL” button.
|
||||
cy.findByText(/show sql/i).click();
|
||||
cy.findByText(/hide sql/i).should("exist");
|
||||
|
||||
// See the “Select targets” input
|
||||
cy.findByText(/select targets/i).should("exist");
|
||||
|
||||
// NOT see and edit “Query name,” “Description,” “SQL”, and “Observer can run” fields.
|
||||
cy.findByLabelText(/query name/i).should("not.exist");
|
||||
cy.findByLabelText(/description/i).should("not.exist");
|
||||
cy.findByLabelText(/observers can run/i).should("not.exist");
|
||||
cy.get(".ace_scroller")
|
||||
.click({ force: true })
|
||||
.type("{selectall}{backspace}SELECT * FROM windows_crashes;");
|
||||
cy.findByText(/SELECT * FROM windows_crashes;/i).should("not.exist");
|
||||
|
||||
// NOT see a the “Select targets” input if the saved query has `observer_can_run` set to false.
|
||||
// cy.findByText(/select targets/i).should("not.exist");
|
||||
// ^^ TODO confirm if this restriction applies to a dual-role user like Marco
|
||||
|
||||
// NOT see a the “Teams” section in the Select target picker. This picker is summoned when the “Select targets” field is selected.
|
||||
// ^^ TODO confirm if this restriction applies to a dual-role user like Marco
|
||||
});
|
||||
|
||||
it("Can perform the appropriate maintainer actions", () => {
|
||||
cy.login("marco@organization.com", "user123#");
|
||||
cy.visit("/");
|
||||
|
||||
// Ensure page is loaded and appropriate nav links are displayed
|
||||
cy.contains("All hosts");
|
||||
cy.get("nav").within(() => {
|
||||
cy.findByText(/hosts/i).should("exist");
|
||||
cy.findByText(/queries/i).should("exist");
|
||||
cy.findByText(/packs/i).should("not.exist");
|
||||
cy.findByText(/settings/i).should("not.exist");
|
||||
});
|
||||
|
||||
// On the hosts page, they should…
|
||||
|
||||
// See the “Teams” column in the Hosts table
|
||||
// cy.get("thead").contains(/team/i).should("exist");
|
||||
// ^^TODO hosts table is not rendering because we need new forEach script/command for admin to assign team after the host is added
|
||||
|
||||
// See and select the “Add new host” button
|
||||
cy.findByText(/add new host/i).click();
|
||||
|
||||
// See the “Select a team for this new host” in the Add new host modal. This modal appears after the user selects the “Add new host” button
|
||||
cy.get(".add-host-modal__team-dropdown-wrapper").within(() => {
|
||||
cy.findByText(/select a team for this new host/i).should("exist");
|
||||
cy.get(".Select").within(() => {
|
||||
cy.findByText(/select a team/i).click();
|
||||
cy.findByText(/no team/i).should("exist");
|
||||
// cy.findByText(/apples/i).should("exist");
|
||||
// cy.findByText(/oranges/i).should("not exist");
|
||||
// ^^TODO add back these assertions after dropdown bug is fixed
|
||||
});
|
||||
});
|
||||
cy.findByRole("button", { name: /done/i }).click();
|
||||
|
||||
// On the Host details page, they should…
|
||||
// cy.visit("/hosts/1");
|
||||
// ^^TODO hosts details page returning 403 likely because we need new forEach script/command for admin to assign team after the host is added
|
||||
|
||||
// See and select the “Create new query” button in the Select a query modal. This modal appears after the user selects the “Query” button
|
||||
// cy.findByRole("button", { name: /query/i }).click();
|
||||
// cy.findByRole("button", { name: /create custom query/i }).should("exist");
|
||||
// cy.get(".modal__ex").within(() => {
|
||||
// cy.findByRole("button").click();
|
||||
// });
|
||||
// ^^TODO hosts details page returning 403 likely because we need new forEach script/command for admin to assign team after the host is added
|
||||
|
||||
// On the Queries manage page, they should…
|
||||
cy.visit("/queries/manage");
|
||||
|
||||
// See and select the “Create new query” button
|
||||
cy.findByText(/create new query/i).click();
|
||||
cy.findByText(/custom query/i).should("exist");
|
||||
cy.findByRole("button", { name: "Run" }).should("exist");
|
||||
cy.findByRole("button", { name: "Save" }).should("not.exist");
|
||||
|
||||
cy.get(".ace_scroller")
|
||||
.click({ force: true })
|
||||
.type("{selectall}{backspace}SELECT * FROM windows_crashes;");
|
||||
|
||||
cy.get(".target-select").within(() => {
|
||||
cy.findByText(/Label name, host name, IP address, etc./i).click();
|
||||
cy.findByText(/teams/i).should("exist");
|
||||
cy.findByText(/apples/i).should("not.exist"); // Marco is only an observer on team apples
|
||||
cy.findByText(/oranges/i) // Marco is a maintainer on team oranges
|
||||
.parent()
|
||||
.parent()
|
||||
.within(() => {
|
||||
cy.findByText(/0 hosts/i).should("exist");
|
||||
// ^^TODO modify for expected host count once hosts are seeded
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in a new issue