Elgato_dark/fleet
1
0
Fork 0
mirror of https://github.com/fleetdm/fleet synced 2026-05-23 08:58:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 111

Website: update logged warnings in receive-from-zoom (#30769)

Browse source 
Closes: https://github.com/fleetdm/fleet/issues/30719

Changes:
- Updated the logged warnings in the receive-from-zoom webhook to
include the payload sent by zoom if the zoom API returns a 404 response
when the webhook attempts to get information about the call.
- Updated the receive-from-zoom webhook to log a detailed warning if a
speaker is missing an expected value.
This commit is contained in:
Eric 2025-07-10 18:01:09 -05:00 committed by GitHub
parent 5716d52e23
commit 3f734e53da
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
website/api/controllers/webhooks/receive-from-zoom.js vendored
View file

@ -91,7 +91,7 @@ module.exports = {
}
})
.intercept({raw: {statusCode: 404}}, (err)=>{
sails.log.warn(`The receive-from-zoom webhook received an event (type: ${event}) about a Zoom call (id: ${idOfCallToGenerateTranscriptFor}), the Zoom API returned a 404 response when a request was sent to get information about the call. Full error: ${require('util').inspect(err, {depth: 3})}`);
sails.log.warn(`The receive-from-zoom webhook received an event (type: ${event}) about a Zoom call (id: ${idOfCallToGenerateTranscriptFor}), the Zoom API returned a 404 response when a request was sent to get information about the call. Full payload from Zoom: ${require('util').inpsect(payload, {depth: null})} Full error: ${require('util').inspect(err, {depth: 3})}`);
return 'callInfoNotFound';
}).intercept((err)=>{
return new Error(`When sending a request to get information about a Zoom recording, an error occured. Full error ${require('util').inspect(err, {depth: 3})}`);
@ -106,7 +106,7 @@ module.exports = {
}
})
.intercept({raw: {statusCode: 404}}, (err)=>{
sails.log.warn(`The receive-from-zoom webhook received an event (type: ${event}) about a Zoom call (id: ${idOfCallToGenerateTranscriptFor}), the Zoom API returned a 404 response when a request was sent to get a transcript of the call. Full error: ${require('util').inspect(err, {depth: 3})}`);
sails.log.warn(`The receive-from-zoom webhook received an event (type: ${event}) about a Zoom call (id: ${idOfCallToGenerateTranscriptFor}), the Zoom API returned a 404 response when a request was sent to get a transcript of the call. Full payload from Zoom: ${require('util').inpsect(payload, {depth: null})} Full error: ${require('util').inspect(err, {depth: 3})}`);
return 'callTranscriptNotFound';
}).intercept((err)=>{
return new Error(`When sending a request to get a transcript of a Zoom recording, an error occured. Full error ${require('util').inspect(err, {depth: 3})}`);
@ -138,6 +138,11 @@ module.exports = {
// Transcripts are ordered by an item_id, but separaterd by speaker.
let allTranscriptLines = [];
for(let speaker of allSpeakersOnThisCall) {
if(!speaker.transcripts) {
// Log a warning if a speaker on this call is missing a transcripts value, and proceed.
sails.log.warn(`When the receive-from-zoom webhook attempted to create a call transcript of a Zoom meeting (call id: ${idOfCallToGenerateTranscriptFor}), a speaker on the call is missing an expected 'transcripts' value. Speaker information returned from the Zoom API: ${require('util').inspect(speaker)}`);
continue;
}
for(let line of speaker.transcripts) {
// Rebuild a list of lines in the call transcript and attach the speakers name to eac hline in the transcript
allTranscriptLines.push({
@ -147,7 +152,6 @@ module.exports = {
});
}
}
let allSpokenWordsOrderedById = _.sortBy(allTranscriptLines, 'id');
let transcript = '';