Elgato_dark/fleet
1
0
Fork 0
mirror of https://github.com/fleetdm/fleet synced 2026-05-23 08:58:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 111

Add PR review to daily standup, remove incoming bug triage (#37090)

Browse source
This commit is contained in:
Luke Heath 2025-12-11 13:31:51 -08:00 committed by GitHub
parent ae0d30fe48
commit 3a183e6772
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 8 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
docs/Contributing/rituals/daily-standup.md
View file

@ -12,10 +12,14 @@ Ritual DRI: EM or assigned team member.
1. Share screen and open the team's GitHub Projects board.
2. Call on each participant and filter the project board to that assignee.
3. Participant answers the questions in the agenda below. If there are blockers, they are added to the parking lot and the standup continues.
4. Call on the next participant until everyone, including the ritual DRI, has provided an update.
5. Complete incoming bug review.
6. End the Daily Standup for everyone except those with parking lot issues.
7. Go through each parking lot item with the relevant participants and define and assign TODOs to resolve the blocker.
4. Call on the next participant until everyone, including the ritual DRI, has provided an update.
5. Open [GitHub pull requests](https://github.com/pulls) filtered using the template below after being modified to include each product group member:
`is:open is:pr archived:false org:fleetdm org:osquery draft:false sort:created-asc author:sgress454 author:lucasmrod`
6. Call out verbally any PRs open for more than the time to merge KPI goal (24 hours).
7. End the Daily Standup for everyone except those with parking lot issues.
8. Go through each parking lot item with the relevant participants and define and assign TODOs to resolve the blocker.
You can find our time to merge and other detailed engineering metrics on the [Grafana engineering metrics project](https://fleeteng.grafana.net/d/b97a629f-3626-4a28-9781-0fa3c8427897/engineering-metrics?orgId=1&from=now-90d&to=now&timezone=browser&var-user=$__all&var-user_group=$__all&var-issue_type=$__all).
> To determine order of standup, some ideas are alphabetical order, [wheel of names](https://wheelofnames.com/), or random. Ritual DRI should call on participants and not wait for volunteers.
@ -29,24 +33,3 @@ Ritual DRI: EM or assigned team member.
### Notes
- See [daily standup definition](https://fleetdm.com/handbook/company/product-groups#sprint-ceremonies) in the handbook.
## Incoming bug review
Each bug review should take less than one minute. The intent is not to debug, but to acknowledge, assign, and share any immediate context as comments on the issue.
1. Open the [Fleet GitHub issue list filtered to the labels](https://github.com/fleetdm/fleet/issues?q=is%3Aissue%20state%3Aopen%20label%3Abug%20label%3A%3Areproduce) `bug` and `:reproduce`.
2. Make sure there are no new bugs without a product group label. If there are, add the appropriate product group label.
3. Filter the list by `bug`, `:reproduce`, and your product group label.
4. For each item, quickly move through the decision flow chart below.
```mermaid
flowchart TD
A[Is this a bug?] -->|Yes| B[Assign QA engineer timebox 30–60 min later today]
A -->|No| C[Close with comment]
B --> D[QA reproduces bug?]
D -->|Yes| E[Move to Inbox Add :product, remove :reproduce]
D -->|No| F[Comment asking for more info. If it's a customer reported bug, add :help-customers]
F --> G[Wait 1 week for response]
G -->|No response| H[Close with comment Can reopen if more info provided]
G -->|Response| B
```