From 39da3fd84dcc75eab8387b932cfcc21c661b7a08 Mon Sep 17 00:00:00 2001 From: gillespi314 <73313222+gillespi314@users.noreply.github.com> Date: Mon, 11 Oct 2021 10:13:10 -0500 Subject: [PATCH] Fix display value for policy update interval (#2468) --- changes/2460-osquery-policy-update-interval | 1 + frontend/interfaces/config.ts | 1 + .../policies/ManagePoliciesPage/ManagePoliciesPage.tsx | 8 ++++---- 3 files changed, 6 insertions(+), 4 deletions(-) create mode 100644 changes/2460-osquery-policy-update-interval diff --git a/changes/2460-osquery-policy-update-interval b/changes/2460-osquery-policy-update-interval new file mode 100644 index 0000000000..a799e72a23 --- /dev/null +++ b/changes/2460-osquery-policy-update-interval @@ -0,0 +1 @@ +* Change update interval displayed in policies page info banner from osquery_detail to osquery_policy \ No newline at end of file diff --git a/frontend/interfaces/config.ts b/frontend/interfaces/config.ts index 30a0a48386..0ea04849f6 100644 --- a/frontend/interfaces/config.ts +++ b/frontend/interfaces/config.ts @@ -95,6 +95,7 @@ export interface IConfig { host_expiry_window: number; agent_options: string; osquery_detail: number; + osquery_policy: number; tier: string; organization: string; device_count: number; diff --git a/frontend/pages/policies/ManagePoliciesPage/ManagePoliciesPage.tsx b/frontend/pages/policies/ManagePoliciesPage/ManagePoliciesPage.tsx index 8570c311cb..f8425bd78c 100644 --- a/frontend/pages/policies/ManagePoliciesPage/ManagePoliciesPage.tsx +++ b/frontend/pages/policies/ManagePoliciesPage/ManagePoliciesPage.tsx @@ -35,7 +35,7 @@ import TeamsDropdown from "./components/TeamsDropdown"; const baseClass = "manage-policies-page"; const DOCS_LINK = - "https://fleetdm.com/docs/deploying/configuration#osquery_detail_update_interval"; + "https://fleetdm.com/docs/deploying/configuration#osquery-policy-update-interval"; const renderInheritedPoliciesButtonText = ( showPolicies: boolean, @@ -106,7 +106,7 @@ const ManagePolicyPage = (managePoliciesPageProps: { const [showRemovePoliciesModal, setShowRemovePoliciesModal] = useState(false); const [showInheritedPolicies, setShowInheritedPolicies] = useState(false); const [updateInterval, setUpdateInterval] = useState( - "osquery detail update interval" + "osquery policy update interval" ); // ===== local state @@ -302,10 +302,10 @@ const ManagePolicyPage = (managePoliciesPageProps: { selectedTeamId, ]); - // Pull osquery detail update interval value from config, reformat, and set as updateInterval. + // Pull osquery policy update interval value from config, reformat, and set as updateInterval. useEffect(() => { if (config) { - const { osquery_detail: interval } = config; + const { osquery_policy: interval } = config; interval && setUpdateInterval(secondsToHms(inMilliseconds(interval) / 1000)); }