Elgato_dark/fleet
1
0
Fork 0
mirror of https://github.com/fleetdm/fleet synced 2026-05-24 01:18:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 59

Fleet UI: Tarballz allow uninstall bug fix (#31607)

Browse source
This commit is contained in:
RachelElysia 2025-08-05 14:27:58 -04:00 committed by GitHub
parent a19c2f7669
commit 30d60dce1a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 109 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

98
frontend/pages/hosts/details/cards/HostSoftwareLibrary/HostInstallerActionCell/HostInstallerActionCell.tests.tsx
View file

@ -578,4 +578,102 @@ describe("HostInstallerActionCell component", () => {
expect(screen.getByTestId("trash-icon")).toBeInTheDocument();
expect(uninstallBtn.closest("button")).toBeDisabled();
});
it("renders Reinstall and Uninstall buttons for tgz package with no installed_versions", () => {
render(
<HostInstallerActionCell
software={{
...defaultSoftware,
source: "tgz_packages",
ui_status: "installed",
status: "installed",
software_package: mockSoftwarePackage,
installed_versions: [], // no versions ever show for tgz packages
app_store_app: null,
}}
onClickInstallAction={noop}
onClickUninstallAction={noop}
baseClass={baseClass}
hostScriptsEnabled
hostMDMEnrolled
/>
);
const installBtn = screen.getByTestId(`${baseClass}__install-button--test`);
expect(installBtn).toHaveTextContent("Reinstall");
expect(screen.getByTestId("refresh-icon")).toBeInTheDocument();
expect(installBtn.closest("button")).toBeEnabled();
const uninstallBtn = screen.getByTestId(
`${baseClass}__uninstall-button--test`
);
expect(uninstallBtn).toHaveTextContent("Uninstall");
expect(screen.getByTestId("trash-icon")).toBeInTheDocument();
expect(uninstallBtn.closest("button")).toBeEnabled();
});
it("renders disabled Reinstall and disabled Uninstall buttons for tgz package with no installed_versions when uninstall pending", () => {
render(
<HostInstallerActionCell
software={{
...defaultSoftware,
source: "tgz_packages",
ui_status: "pending_uninstall",
status: "pending_uninstall",
software_package: mockSoftwarePackage,
installed_versions: [], // no versions ever show for tgz packages
app_store_app: null,
}}
onClickInstallAction={noop}
onClickUninstallAction={noop}
baseClass={baseClass}
hostScriptsEnabled
hostMDMEnrolled
/>
);
const installBtn = screen.getByTestId(`${baseClass}__install-button--test`);
expect(installBtn).toHaveTextContent("Reinstall");
expect(screen.getByTestId("refresh-icon")).toBeInTheDocument();
expect(installBtn.closest("button")).toBeDisabled();
const uninstallBtn = screen.getByTestId(
`${baseClass}__uninstall-button--test`
);
expect(uninstallBtn).toHaveTextContent("Uninstall");
expect(screen.getByTestId("trash-icon")).toBeInTheDocument();
expect(uninstallBtn.closest("button")).toBeDisabled();
});
it("renders Reinstall and Retry uninstall buttons for tgz package with no installed_versions when uninstall failed", () => {
render(
<HostInstallerActionCell
software={{
...defaultSoftware,
source: "tgz_packages",
ui_status: "failed_uninstall",
status: "failed_uninstall",
software_package: mockSoftwarePackage,
installed_versions: [], // no versions ever show for tgz packages
app_store_app: null,
}}
onClickInstallAction={noop}
onClickUninstallAction={noop}
baseClass={baseClass}
hostScriptsEnabled
hostMDMEnrolled
/>
);
const installBtn = screen.getByTestId(`${baseClass}__install-button--test`);
expect(installBtn).toHaveTextContent("Reinstall");
expect(installBtn.closest("button")).toBeEnabled();
const uninstallBtn = screen.getByTestId(
`${baseClass}__uninstall-button--test`
);
expect(uninstallBtn).toHaveTextContent("Retry uninstall");
expect(uninstallBtn.closest("button")).toBeEnabled();
// Both reinstall and retry uninstall have the same icon
const refreshIcons = screen.getAllByTestId("refresh-icon");
expect(refreshIcons).toHaveLength(2);
});
});

13
frontend/pages/hosts/details/cards/HostSoftwareLibrary/HostInstallerActionCell/HostInstallerActionCell.tsx
View file

@ -201,11 +201,20 @@ export const HostInstallerActionCell = ({
}
}, [status, ui_status]);
const installedVersionsDetected =
installed_versions && installed_versions.length > 0;
const installedTgzPackageDetected =
software.source === "tgz_packages" &&
(ui_status === "installed" ||
ui_status === "pending_uninstall" ||
ui_status === "uninstalling" ||
ui_status === "failed_uninstall");
const canUninstallSoftware =
!app_store_app &&
!!software_package &&
installed_versions &&
installed_versions.length > 0;
(installedVersionsDetected || installedTgzPackageDetected);
return (
<div className={`${baseClass}__item-actions`}>