Elgato_dark/fleet
1
0
Fork 0
mirror of https://github.com/fleetdm/fleet synced 2026-05-24 09:28:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 31

Hotfix: add empty host slice validation in ListHosts (#13483)

Browse source
This commit is contained in:
Tim Lee 2023-08-23 13:57:18 -06:00 committed by GitHub
parent 699701a2db
commit 29e48f402a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
server/datastore/mysql/policies.go
View file

@ -748,6 +748,10 @@ func (ds *Datastore) CleanupPolicyMembership(ctx context.Context, now time.Time)
}
func (ds *Datastore) UpdatePolicyFailureCountsForHosts(ctx context.Context, hosts []*fleet.Host) ([]*fleet.Host, error) {
if len(hosts) == 0 {
return hosts, nil
}
// Get policy failure counts for each host
hostIDs := make([]uint, 0, len(hosts))

5
server/datastore/mysql/policies_test.go
View file

@ -2271,4 +2271,9 @@ func testUpdatePolicyFailureCountsForHosts(t *testing.T, ds *Datastore) {
// host 3 doesn't have any policy membership
assert.Equal(t, 0, hostsUpdated[3].TotalIssuesCount)
assert.Equal(t, 0, hostsUpdated[3].FailingPoliciesCount)
// return empty list if no hosts are passed
hostsUpdated, err = ds.UpdatePolicyFailureCountsForHosts(ctx, []*fleet.Host{})
require.NoError(t, err)
require.Len(t, hostsUpdated, 0)
}