diff --git a/.github/scripts/dogfood-policy-updater-latest-macos.sh b/.github/scripts/dogfood-policy-updater-latest-macos.sh index c98077b166..6952c4a8a5 100644 --- a/.github/scripts/dogfood-policy-updater-latest-macos.sh +++ b/.github/scripts/dogfood-policy-updater-latest-macos.sh @@ -114,7 +114,7 @@ if [ "$policy_version_number" != "$latest_macos_version" ]; then echo "Adding reviewers to PR #$pr_number..." # Prepare the reviewers data payload - reviewers_data=$(jq -n --argjson reviewers '["allenhouchins","harrisonravazzolo"]' '{reviewers: $reviewers}') + reviewers_data=$(jq -n --arg r1 "harrisonravazzolo" --arg r2 "allenhouchins" '{reviewers: [$r1, $r2]}') # Request reviewers for the pull request review_response=$(curl -s -X POST \ @@ -123,6 +123,10 @@ if [ "$policy_version_number" != "$latest_macos_version" ]; then -d "$reviewers_data" \ "https://api.github.com/repos/$REPO_OWNER/$REPO_NAME/pulls/$pr_number/requested_reviewers") + # Troubleshooting + echo "Reviewers API response:" + echo "$review_response" | jq . + if echo "$review_response" | grep -q "errors"; then echo "Error: Failed to add reviewers. Response: $review_response" exit 1 diff --git a/it-and-security/lib/macos/policies/latest-macos.yml b/it-and-security/lib/macos/policies/latest-macos.yml index 997aa394af..d3b9f19402 100644 --- a/it-and-security/lib/macos/policies/latest-macos.yml +++ b/it-and-security/lib/macos/policies/latest-macos.yml @@ -1,5 +1,5 @@ - name: macOS - Operating system up to date - query: SELECT 1 FROM os_version WHERE version >= '15.3.1'; + query: SELECT 1 FROM os_version WHERE version >= '15.3'; critical: true description: Using an outdated macOS version risks exposure to security vulnerabilities and potential system instability. resolution: Please find time to run Software Update.  > System Settings > Software Update