Elgato_dark/fleet
1
0
Fork 0
mirror of https://github.com/fleetdm/fleet synced 2026-04-21 13:37:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 91

up default limit for software batch (#41827)

Browse source 
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** None

Based on a Slack thread from a customer, this endpoint seems like it was
missed

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files)
for more information.

## Testing

- [x] QA'd all new/changed functionality manually
This commit is contained in:
Magnus Jensen 2026-03-17 10:20:09 -05:00 committed by GitHub
parent 0af8547280
commit 190652cc65
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changes/up-default-software-batch Normal file
View file

@ -0,0 +1 @@
- Upped the default limit for the software batch endpoint, from 1MiB to 25MiB

1
server/fleet/request.go
View file

@ -13,6 +13,7 @@ const (
MaxProfileSize int64 = 1.5 * units.MiB // 1.5 to allow for roughly 1MB content, and B64 encoding
MaxBatchProfileSize int64 = 25 * units.MiB
MaxEULASize int64 = 25 * units.MiB
MaxSoftwareBatchSize int64 = 25 * units.MiB // Takes multiple installers, with scripts and queries
MaxMDMCommandSize int64 = 2 * units.MiB
// MaxMultiScriptQuerySize, sets a max size for payloads that take multiple scripts and SQL queries.
MaxMultiScriptQuerySize int64 = 5 * units.MiB

2
server/service/handler.go
View file

@ -417,7 +417,7 @@ func attachFleetAPIRoutes(r *mux.Router, svc fleet.Service, config config.FleetC
getSoftwareInstallResultsRequest{})
// POST /api/_version_/fleet/software/batch is asynchronous, meaning it will start the process of software download+upload in the background
// and will return a request UUID to be used in GET /api/_version_/fleet/software/batch/{request_uuid} to query for the status of the operation.
ue.POST("/api/_version_/fleet/software/batch", batchSetSoftwareInstallersEndpoint, batchSetSoftwareInstallersRequest{})
ue.WithRequestBodySizeLimit(fleet.MaxSoftwareBatchSize).POST("/api/_version_/fleet/software/batch", batchSetSoftwareInstallersEndpoint, batchSetSoftwareInstallersRequest{})
ue.GET("/api/_version_/fleet/software/batch/{request_uuid}", batchSetSoftwareInstallersResultEndpoint, batchSetSoftwareInstallersResultRequest{})
// software title custom icons