Elgato_dark/fleet
1
0
Fork 0
mirror of https://github.com/fleetdm/fleet synced 2026-05-22 16:39:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 122

13472 clipped banner (#14396)

Browse source
This commit is contained in:
Jacob Shandling 2023-10-09 14:51:05 -07:00 committed by GitHub
parent eb327faabf
commit 18b80c409b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 32 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
frontend/pages/queries/details/QueryDetailsPage/QueryDetailsPage.tsx
View file

@ -25,12 +25,15 @@ import TooltipWrapper from "components/TooltipWrapper/TooltipWrapper";
import QueryAutomationsStatusIndicator from "pages/queries/ManageQueriesPage/components/QueryAutomationsStatusIndicator/QueryAutomationsStatusIndicator";
import DataError from "components/DataError/DataError";
import LogDestinationIndicator from "components/LogDestinationIndicator/LogDestinationIndicator";
import CustomLink from "components/CustomLink";
import InfoBanner from "components/InfoBanner";
import QueryReport from "../components/QueryReport/QueryReport";
import NoResults from "../components/NoResults/NoResults";
import {
DEFAULT_SORT_HEADER,
DEFAULT_SORT_DIRECTION,
QUERY_REPORT_RESULTS_LIMIT,
} from "./QueryDetailsPageConfig";
interface IQueryDetailsPageProps {
@ -151,6 +154,8 @@ const QueryDetailsPage = ({
const isLoading = isStoredQueryLoading || isQueryReportLoading;
const isApiError = storedQueryError || queryReportError;
const isClipped =
queryReport && queryReport.results.length >= QUERY_REPORT_RESULTS_LIMIT;
const renderHeader = () => {
const canEditQuery =
@ -232,6 +237,25 @@ const QueryDetailsPage = ({
);
};
const renderClippedBanner = () => (
<InfoBanner
color="yellow"
cta={
<CustomLink
url="https://www.fleetdm.com/support"
text="Get help"
newTab
/>
}
>
<div>
<b>Report clipped.</b> A sample of this query&apos;s results is included
below. You can still use query automations to complete this report in
your log destination.
</div>
</InfoBanner>
);
const renderReport = () => {
const disabledCachingGlobally = true; // TODO: Update accordingly to config?.server_settings.query_reports_disabled
const discardDataEnabled = true; // TODO: Update accordingly to storedQuery?.discard_data
@ -270,6 +294,7 @@ const QueryDetailsPage = ({
<MainContent className={baseClass}>
<div className={`${baseClass}__wrapper`}>
{renderHeader()}
{isClipped && renderClippedBanner()}
{renderReport()}
</div>
</MainContent>

2
frontend/pages/queries/details/QueryDetailsPage/QueryDetailsPageConfig.tsx
View file

@ -11,3 +11,5 @@ export type QueryDetailsPageQueryParams = Record<
export const DEFAULT_SORT_HEADER = "host_name";
export const DEFAULT_SORT_DIRECTION = "asc";
export const QUERY_REPORT_RESULTS_LIMIT = 1000;

5
frontend/pages/queries/details/QueryDetailsPage/_styles.scss
View file

@ -1,4 +1,9 @@
.query-details-page {
&__wrapper {
display: flex;
flex-direction: column;
gap: $pad-large;
}
&__title-bar {
display: flex;
justify-content: space-between;

2
frontend/pages/queries/details/components/QueryReport/_styles.scss
View file

@ -1,7 +1,5 @@
.query-report {
&__wrapper {
margin-top: $pad-large;
.host_id__header {
width: 95px; // Min width for 6 digits host IDs
}