Elgato_dark/fleet
1
0
Fork 0
mirror of https://github.com/fleetdm/fleet synced 2026-05-23 17:08:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 83

Fleet UI: (Unreleased bug) Team admin/maintainers cannot save global queries (#12878)

Browse source
This commit is contained in:
RachelElysia 2023-07-20 15:38:09 -04:00 committed by GitHub
parent 0aa293201a
commit 099ed43acf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 34 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
frontend/pages/queries/QueryPage/components/QueryForm/QueryForm.tsx
View file

@ -30,6 +30,7 @@ import {
} from "interfaces/schedulable_query";
import { SelectedPlatformString } from "interfaces/platform";
import queryAPI from "services/entities/queries";
import { COLORS } from "styles/var/colors";
import { IAceEditor } from "react-ace/lib/types";
import ReactTooltip from "react-tooltip";
@ -670,14 +671,40 @@ const QueryForm = ({
</Button>
)}
<div className="query-form__button-wrap--save-query-button">
<Button
className="save-loading"
variant="brand"
onClick={promptSaveQuery()}
isLoading={isQueryUpdating}
<div
data-tip
data-for="save-query-button"
// Tooltip shows for team maintainer/admins viewing global queries
data-tip-disable={
!(isAnyTeamMaintainerOrTeamAdmin && !storedQuery?.team_id)
}
>
Save
</Button>
<Button
className="save-loading"
variant="brand"
onClick={promptSaveQuery()}
// Button disabled for team maintainer/admins viewing global queries
disabled={
isAnyTeamMaintainerOrTeamAdmin && !storedQuery?.team_id
}
isLoading={isQueryUpdating}
>
Save
</Button>
</div>{" "}
<ReactTooltip
className={`save-query-button-tooltip`}
place="top"
effect="solid"
backgroundColor={COLORS["tooltip-bg"]}
id="save-query-button"
data-html
>
<>
You can only save changes
<br /> to a team level query.
</>
</ReactTooltip>
</div>
</>
)}