From 07f8cb107f27b06305f1c47237cf85fcaa509b98 Mon Sep 17 00:00:00 2001 From: RachelElysia <71795832+RachelElysia@users.noreply.github.com> Date: Fri, 14 Jul 2023 12:58:20 -0400 Subject: [PATCH] Fix: 12743 observer plus (#12772) ## Issue Cerra #12743 ## Fix of the fix - Fix of team observer + was catching global observer + # Checklist for submitter If some of the following don't apply, delete the relevant line. - [x] Manual QA for all new/changed functionality --- .../pages/queries/QueryPage/components/QueryForm/QueryForm.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/pages/queries/QueryPage/components/QueryForm/QueryForm.tsx b/frontend/pages/queries/QueryPage/components/QueryForm/QueryForm.tsx index 9ce72aa919..a3f7b80ad0 100644 --- a/frontend/pages/queries/QueryPage/components/QueryForm/QueryForm.tsx +++ b/frontend/pages/queries/QueryPage/components/QueryForm/QueryForm.tsx @@ -585,7 +585,7 @@ const QueryForm = ({ const noEditPermissions = (isGlobalObserver && !isObserverPlus) || // Global observer but not Observer+ (isObserverPlus && queryIdForEdit !== 0) || // Global observer+ on existing query - (isOnlyObserver && !isAnyTeamObserverPlus) || // Only team observer but not team Observer+ + (isOnlyObserver && !isAnyTeamObserverPlus && !isGlobalObserver) || // Only team observer but not team Observer+ (isAnyTeamObserverPlus && // Team Observer+ on existing query !isAnyTeamMaintainerOrTeamAdmin && queryIdForEdit !== 0);