Elgato_dark/fleet - Forgejo: Beyond coding. We Forge.

Elgato_dark/fleet

mirror of https://github.com/fleetdm/fleet synced 2026-05-23 00:49:03 +00:00

2 lines

84 B

Text

Raw Normal View History

Handle edge case when parsing SQL abstract syntax tree to determine platform compatibility (#15806) ## Addresses #15035 <img width="1455" alt="Screenshot 2023-12-21 at 8 11 27 AM" src="https://github.com/fleetdm/fleet/assets/61553566/f1b17bf9-0c68-4119-9b45-559391b48293"> The bug stemmed from the presence of nodes of the following structure in the SQL abstract syntax tree generated by the `sqlite-parser` package, whos `.name` was incorrectly being assumed to be a `string` and included as a table to check compatibility of. Since it is not actually a table, this was disqualifying the entire query from compatibility with any OS: <img width="253" alt="Screenshot 2023-12-21 at 8 31 38 AM" src="https://github.com/fleetdm/fleet/assets/61553566/df4cb874-6edd-44f5-a516-cd538d04cc1a"> ## Checklist for submitter - [x] Changes file added for user-visible changes in `changes/` - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Jacob Shandling <jacob@fleetdm.com>

2024-01-03 20:40:33 +00:00

- Fix a bug where OS compatibility was not correctly calculated for certain queries