Elgato_dark/fleet
1
0
Fork 0
mirror of https://github.com/fleetdm/fleet synced 2026-04-21 13:37:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 91
fleet/CODEOWNERS

142 lines
10 KiB
Text
Raw Normal View History

Request review automatically for non-codeowners (#12786) https://github.com/fleetdm/confidential/issues/3146 To test this works: - sam should be able to change ceo handbook and be autoapproved - mike submitting a PR to the ceo handbook should request review from Sam but auto-approve for mike - Jarod's use case of creating an article should now work, even if his PR contains images . --------- Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
2023-07-16 00:56:30 +00:00
##############################################################################################
# ██████╗ ██████╗ ██████╗ ███████╗ ██████╗ ██╗ ██╗███╗ ██╗███████╗██████╗ ███████╗
# ██╔════╝██╔═══██╗██╔══██╗██╔════╝██╔═══██╗██║ ██║████╗ ██║██╔════╝██╔══██╗██╔════╝
# ██║ ██║ ██║██║ ██║█████╗ ██║ ██║██║ █╗ ██║██╔██╗ ██║█████╗ ██████╔╝███████╗
# ██║ ██║ ██║██║ ██║██╔══╝ ██║ ██║██║███╗██║██║╚██╗██║██╔══╝ ██╔══██╗╚════██║
# ╚██████╗╚██████╔╝██████╔╝███████╗╚██████╔╝╚███╔███╔╝██║ ╚████║███████╗██║ ██║███████║
# ╚═════╝ ╚═════╝ ╚═════╝ ╚══════╝ ╚═════╝ ╚══╝╚══╝ ╚═╝ ╚═══╝╚══════╝╚═╝ ╚═╝╚══════╝
##############################################################################################
# ⛔ This file indicates REQUIRED reviewers for changes to certain file paths in this repo.
#
# > How? This "requiredness" is provided natively by GitHub. If a team is specified, then
# > the logic behaves slightly differently. See GitHub's latest documentation on CODEOWNERS
Deduplicate config, auto-remove #g-ceo and #handbook labels when appropriate, improve comments (#12915) - Deduplicate config for DRI vs CODEOWNERS (this eliminates extra notifications folks were receiving) - auto-remove #g-ceo and #handbook labels when appropriate - improve comments
2023-07-22 19:07:54 +00:00
# > for more information. CODEOWNERS is especially useful for paths that usually end up
# > in PRs with lots of other reviewers.)
Request review automatically for non-codeowners (#12786) https://github.com/fleetdm/confidential/issues/3146 To test this works: - sam should be able to change ceo handbook and be autoapproved - mike submitting a PR to the ceo handbook should request review from Sam but auto-approve for mike - Jarod's use case of creating an article should now work, even if his PR contains images . --------- Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
2023-07-16 00:56:30 +00:00
#
Deduplicate config, auto-remove #g-ceo and #handbook labels when appropriate, improve comments (#12915) - Deduplicate config for DRI vs CODEOWNERS (this eliminates extra notifications folks were receiving) - auto-remove #g-ceo and #handbook labels when appropriate - improve comments
2023-07-22 19:07:54 +00:00
# ⚠️ For file paths not listed, the DRI is instead indicated in website/config/custom.js.
# Regardless of whether a path's DRI is configured in CODEOWNERS or custom.js, the DRI is
# automatically requested for review when changes are proposed.
# [!] But beware: No path should ever be configured as a DRI in both CODEOWNERS _and_
# the website config.
# [!] In addition, no path should ever be configured in CODEOWNERS if there is ALSO one
# of its ancestral paths configured in website/config/custom.js.
Request review automatically for non-codeowners (#12786) https://github.com/fleetdm/confidential/issues/3146 To test this works: - sam should be able to change ceo handbook and be autoapproved - mike submitting a PR to the ceo handbook should request review from Sam but auto-approve for mike - Jarod's use case of creating an article should now work, even if his PR contains images . --------- Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
2023-07-16 00:56:30 +00:00
#
# ✅ Some paths also have multiple individuals who are allowed to make changes without review,
# even though they are not the DRI. These are called "maintainers".
#
# For more information on how this works, see:
# - What is a DRI and how is this configured? https://fleetdm.com/handbook/company/why-this-way#why-direct-responsibility
# - Historical context: https://github.com/fleetdm/fleet/pull/12786
##############################################################################################
##############################################################################################
Deduplicate config, auto-remove #g-ceo and #handbook labels when appropriate, improve comments (#12915) - Deduplicate config for DRI vs CODEOWNERS (this eliminates extra notifications folks were receiving) - auto-remove #g-ceo and #handbook labels when appropriate - improve comments
2023-07-22 19:07:54 +00:00
# 🚀 Golang files and other files related to the core product backend.
Request review automatically for non-codeowners (#12786) https://github.com/fleetdm/confidential/issues/3146 To test this works: - sam should be able to change ceo handbook and be autoapproved - mike submitting a PR to the ceo handbook should request review from Sam but auto-approve for mike - Jarod's use case of creating an article should now work, even if his PR contains images . --------- Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
2023-07-16 00:56:30 +00:00
# (1 or more Golang-literate engineers is required to review changes.)
# FUTURE: Look for a way to not have this notify every single person in this "github team".
##############################################################################################
Add CODEOWNERS for Go engineering team (#1449) This should result in automatic review requests for everyone the @fleetdm/go group when Go or server related files are touched.
2021-07-22 18:14:10 +00:00
*.go @fleetdm/go
go.sum @fleetdm/go
go.mod @fleetdm/go
/cmd/ @fleetdm/go
Add requirement for multiple product group PR reviews on some code paths (#20055)
2024-06-27 22:23:38 +00:00
/server/ @fleetdm/go
Remove engineering codeowners (#21634)
2024-08-28 16:35:17 +00:00
/ee/server/ @fleetdm/go
update CODEOWNERS to allow fleetdm/go to review orbit code (#22346)
2024-09-25 21:18:18 +00:00
/orbit/ @fleetdm/go
Add @edwardsb as codeowner for .tf files (#3969)
2022-02-01 19:59:11 +00:00
Request review automatically for non-codeowners (#12786) https://github.com/fleetdm/confidential/issues/3146 To test this works: - sam should be able to change ceo handbook and be autoapproved - mike submitting a PR to the ceo handbook should request review from Sam but auto-approve for mike - Jarod's use case of creating an article should now work, even if his PR contains images . --------- Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
2023-07-16 00:56:30 +00:00
##############################################################################################
Deduplicate config, auto-remove #g-ceo and #handbook labels when appropriate, improve comments (#12915) - Deduplicate config for DRI vs CODEOWNERS (this eliminates extra notifications folks were receiving) - auto-remove #g-ceo and #handbook labels when appropriate - improve comments
2023-07-22 19:07:54 +00:00
# 🚀 React files and other files related to the core product frontend.
Request review automatically for non-codeowners (#12786) https://github.com/fleetdm/confidential/issues/3146 To test this works: - sam should be able to change ceo handbook and be autoapproved - mike submitting a PR to the ceo handbook should request review from Sam but auto-approve for mike - Jarod's use case of creating an article should now work, even if his PR contains images . --------- Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
2023-07-16 00:56:30 +00:00
# (1 or more React-literate engineers is required to review changes.)
# FUTURE: Look for a way to not have this notify every single person in this "github team".
##############################################################################################
Add frontend group to codeowners (#9542)
2023-01-27 23:35:38 +00:00
/frontend/ @fleetdm/frontend
Add infrastructure directories to codeowners (#12869)
2023-07-20 22:14:01 +00:00
##############################################################################################
Deduplicate config, auto-remove #g-ceo and #handbook labels when appropriate, improve comments (#12915) - Deduplicate config for DRI vs CODEOWNERS (this eliminates extra notifications folks were receiving) - auto-remove #g-ceo and #handbook labels when appropriate - improve comments
2023-07-22 19:07:54 +00:00
# 🚀 Config as code for infrastructure, internal security and IT use cases, and more.
Add infrastructure directories to codeowners (#12869)
2023-07-20 22:14:01 +00:00
# (1 or more infra-literate engineers is required to review changes.)
# FUTURE: Look for a way to not have this notify every single person in this "github team".
##############################################################################################
Noah is codeowner for dogfood (#17635) - @noahtalerman get's a Toast notification for changes to dogfood (managed via [Fleet's best practice GitOps](https://github.com/fleetdm/fleet-gitops)) Co-authored-by: Sam Pfluger <108141731+Sampfluger88@users.noreply.github.com>
2024-03-15 02:20:11 +00:00
Add dale to infra codeowners (#30479)
2025-07-01 21:14:33 +00:00
/infrastructure/ @rfairburn @ksatter @lukeheath @edwardsb @georgekarrv @BCTBB @ddribeiro
/charts/ @rfairburn @ksatter @lukeheath @edwardsb @georgekarrv @BCTBB @ddribeiro
/terraform/ @rfairburn @ksatter @lukeheath @edwardsb @georgekarrv @BCTBB @ddribeiro
Add infrastructure directories to codeowners (#12869)
2023-07-20 22:14:01 +00:00
Add a few priority CODEOWNERS on top of auto-request automation (#12791)
2023-07-16 02:20:19 +00:00
##############################################################################################
Deduplicate config, auto-remove #g-ceo and #handbook labels when appropriate, improve comments (#12915) - Deduplicate config for DRI vs CODEOWNERS (this eliminates extra notifications folks were receiving) - auto-remove #g-ceo and #handbook labels when appropriate - improve comments
2023-07-22 19:07:54 +00:00
# ⚗️ Reference, config surface, built-in queries, API, and other documentation.
Add a few priority CODEOWNERS on top of auto-request automation (#12791)
2023-07-16 02:20:19 +00:00
#
Deduplicate config, auto-remove #g-ceo and #handbook labels when appropriate, improve comments (#12915) - Deduplicate config for DRI vs CODEOWNERS (this eliminates extra notifications folks were receiving) - auto-remove #g-ceo and #handbook labels when appropriate - improve comments
2023-07-22 19:07:54 +00:00
# (see website/config/custom.js for DRIs of other paths not listed here)
Add a few priority CODEOWNERS on top of auto-request automation (#12791)
2023-07-16 02:20:19 +00:00
##############################################################################################
Add @fleetdm/go to backend patterns, Rachael is back (#30950)
2025-07-16 17:22:11 +00:00
/docs @rachaelshaw
Add Rachael as codeowner for /docs/Contributing (#31254)
2025-07-24 22:32:10 +00:00
/docs/Configuration @rachaelshaw
Add @fleetdm/go to backend patterns, Rachael is back (#30950)
2025-07-16 17:22:11 +00:00
/docs/Contributing @lukeheath # « Contributing guidelines
/docs/Contributing/architecture/mdm @lukeheath @georgekarrv
/docs/Contributing/architecture/orchestration @lukeheath @sharon-fdm
/docs/Contributing/architecture/software @lukeheath @mostlikelee
/docs/Contributing/product-groups/mdm @lukeheath @georgekarrv
/docs/Contributing/product-groups/orchestration @lukeheath @sharon-fdm
/docs/Contributing/product-groups/software @lukeheath @mostlikelee
/docs/Contributing/reference/patterns-backend.md @fleetdm/go
/docs/Contributing/research/mdm @lukeheath @georgekarrv
/docs/Contributing/research/orchestration @lukeheath @sharon-fdm
/docs/Contributing/research/software @lukeheath @mostlikelee
/docs/REST\ API/rest-api.md @rachaelshaw # « REST API reference documentation
/docs/Contributing/reference/api-for-contributors.md @rachaelshaw # « Advanced / contributors-only API reference documentation
/docs/Contributing/reference/audit-logs.md @rachaelshaw # « Advanced / contributors-only audit log documentation
/schema @eashaw # « Data tables (osquery/fleetd schema) documentation
/render.yaml @edwardsb
/it-and-security @allenhouchins
Handbook CODEOWNERS (#13195) Everyone can contribute to the handbook, and page DRIs are expected to keep their pages up to date. To shape and absorb changes, and learn from how GitLab evolved its handbook as that company grew, CEO will ALSO review all PRs that change the handbook before they are merged. (Background: As of mid-2023, there are only ≤3 handbook PRs per weekday on the busiest of weeks. If this increases dramatically, or when time allows the company to prioritize writing down the content design, structure, and vision for the evolution of the handbook, we'll change ) --------- Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
2023-08-10 15:13:36 +00:00
##############################################################################################
Fix auto-approval + CODEOWNER blockage (#18668) - Remove redundant callouts for Luke in issue templates - Fix auto-approval + CODEOWNER blockage cc @lukeheath
2024-05-01 04:07:28 +00:00
# 🌐 Repo automation and change control settings
Handbook CODEOWNERS (#13195) Everyone can contribute to the handbook, and page DRIs are expected to keep their pages up to date. To shape and absorb changes, and learn from how GitLab evolved its handbook as that company grew, CEO will ALSO review all PRs that change the handbook before they are merged. (Background: As of mid-2023, there are only ≤3 handbook PRs per weekday on the busiest of weeks. If this increases dramatically, or when time allows the company to prioritize writing down the content design, structure, and vision for the evolution of the handbook, we'll change ) --------- Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
2023-08-10 15:13:36 +00:00
##############################################################################################
DRIs (#17614) ...
2024-03-14 15:24:53 +00:00
# /CODEOWNERS @mikermcneil # Covered in DRIs
Handbook CODEOWNERS (#13195) Everyone can contribute to the handbook, and page DRIs are expected to keep their pages up to date. To shape and absorb changes, and learn from how GitLab evolved its handbook as that company grew, CEO will ALSO review all PRs that change the handbook before they are merged. (Background: As of mid-2023, there are only ≤3 handbook PRs per weekday on the busiest of weeks. If this increases dramatically, or when time allows the company to prioritize writing down the content design, structure, and vision for the evolution of the handbook, we'll change ) --------- Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
2023-08-10 15:13:36 +00:00
Deduplicate config, auto-remove #g-ceo and #handbook labels when appropriate, improve comments (#12915) - Deduplicate config for DRI vs CODEOWNERS (this eliminates extra notifications folks were receiving) - auto-remove #g-ceo and #handbook labels when appropriate - improve comments
2023-07-22 19:07:54 +00:00
##############################################################################################
Fix auto-approval + CODEOWNER blockage (#18668) - Remove redundant callouts for Luke in issue templates - Fix auto-approval + CODEOWNER blockage cc @lukeheath
2024-05-01 04:07:28 +00:00
# 🌐 Handbook
Deduplicate config, auto-remove #g-ceo and #handbook labels when appropriate, improve comments (#12915) - Deduplicate config for DRI vs CODEOWNERS (this eliminates extra notifications folks were receiving) - auto-remove #g-ceo and #handbook labels when appropriate - improve comments
2023-07-22 19:07:54 +00:00
#
# (see website/config/custom.js for DRIs of other paths not listed here)
##############################################################################################
Add DRIs (#23076)
2024-10-22 15:21:57 +00:00
/handbook/company/README.md @mikermcneil
Update CODEOWNERS (#23279) Transfer codeowner for communiations and leadership to Sam, who will loop me in anytime I need 👀
2024-10-25 23:20:07 +00:00
/handbook/company/communications.md @sampfluger88
/handbook/company/leadership.md @sampfluger88
Add DRIs (#23076)
2024-10-22 15:21:57 +00:00
/handbook/company/why-this-way.md @mikermcneil
/handbook/README.md @mikermcneil
/handbook/company/open-positions.yml @sampfluger88
Update CODEOWNERS (#23279) Transfer codeowner for communiations and leadership to Sam, who will loop me in anytime I need 👀
2024-10-25 23:20:07 +00:00
#/handbook/company/product-groups.md 🤡 Covered in custom.js
Update CODEOWNERS (#27789)
2025-04-02 17:33:13 +00:00
/handbook/company/go-to-market-groups.md @sampfluger88
Update CODEOWNERS (#24314)
2024-12-03 16:20:54 +00:00
/handbook/finance/README.md @sampfluger88
/handbook/finance/finance.rituals.yml @sampfluger88
Combine security docs (#23422)
2024-11-01 15:12:58 +00:00
/handbook/digital-experience/security.md @sampfluger88
Update CODEOWNERS (#24314)
2024-12-03 16:20:54 +00:00
/handbook/digital-experience @sampfluger88
/handbook/customer-success @sampfluger88
Update CODEOWNERS (#27057)
2025-03-12 02:28:50 +00:00
/handbook/marketing @sampfluger88
Update CODEOWNERS (#23279) Transfer codeowner for communiations and leadership to Sam, who will loop me in anytime I need 👀
2024-10-25 23:20:07 +00:00
#/handbook/engineering 🤡 Covered in custom.js
/handbook/sales @sampfluger88
Update CODEOWNERS (#24314)
2024-12-03 16:20:54 +00:00
#/handbook/product-design 🤡 Covered in custom.js
fix CODEOWERS and add Desmi as owner of docs/*.md (#6755) Per the new changes in the [handbook](https://fleetdm.com/handbook/community#how-to-request-a-review-for-markdown-changes-to-the-docs) this adds @Desmi-Dizney as codeowner of `docs/*.md`, this way he is automatically added as a reviewer when a file is changed. Since I was there, I also fixed the mention to actually ping @fleetdm/g-platform
2022-07-20 14:51:57 +00:00
Handbook CODEOWNERS (#13195) Everyone can contribute to the handbook, and page DRIs are expected to keep their pages up to date. To shape and absorb changes, and learn from how GitLab evolved its handbook as that company grew, CEO will ALSO review all PRs that change the handbook before they are merged. (Background: As of mid-2023, there are only ≤3 handbook PRs per weekday on the busiest of weeks. If this increases dramatically, or when time allows the company to prioritize writing down the content design, structure, and vision for the evolution of the handbook, we'll change ) --------- Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
2023-08-10 15:13:36 +00:00
##############################################################################################
Fix auto-approval + CODEOWNER blockage (#18668) - Remove redundant callouts for Luke in issue templates - Fix auto-approval + CODEOWNER blockage cc @lukeheath
2024-05-01 04:07:28 +00:00
# 🌐 GitHub issue templates
Handbook CODEOWNERS (#13195) Everyone can contribute to the handbook, and page DRIs are expected to keep their pages up to date. To shape and absorb changes, and learn from how GitLab evolved its handbook as that company grew, CEO will ALSO review all PRs that change the handbook before they are merged. (Background: As of mid-2023, there are only ≤3 handbook PRs per weekday on the busiest of weeks. If this increases dramatically, or when time allows the company to prioritize writing down the content design, structure, and vision for the evolution of the handbook, we'll change ) --------- Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
2023-08-10 15:13:36 +00:00
##############################################################################################
Fix auto-approval + CODEOWNER blockage (#18668) - Remove redundant callouts for Luke in issue templates - Fix auto-approval + CODEOWNER blockage cc @lukeheath
2024-05-01 04:07:28 +00:00
#/.github/ISSUE_TEMPLATE @mikermcneil @sampfluger88 @lukeheath # Covered in custom.js See https://github.com/fleetdm/fleet/pull/18668
Update CODEOWNERS to include handbook, etc (#7163) * Update CODEOWNERS * Update CODEOWNERS * Update CODEOWNERS * Update CODEOWNERS * Update CODEOWNERS * add articles/ + add leading "/" for CHANGELOG.md so it doesn't inadvertently catch others * Update custom.js * lint fix * Update custom.js
2022-08-11 17:38:00 +00:00
Add website/.sailsrc codeowner (#22889)
2024-10-12 03:25:42 +00:00
##############################################################################################
# 🌐 Fleet website
##############################################################################################
/website/.sailsrc @eashaw # Note: eashaw will not approve any PR that changes this file. This codeowner exists to make sure no changes are committed to the repo.
Set GitHub workflow DRIs (#17777)
2024-03-21 21:04:53 +00:00
##############################################################################################
# 🌐 GitHub workflows
##############################################################################################
/.github/workflows/markdown-link-check-config.json @eashaw
/.github/workflows/deploy-vulnerability-dashboard.yml @eashaw
/.github/workflows/test-website.yml @eashaw
/.github/workflows/test-vulnerability-dashboard-changes.yml @eashaw
/.github/workflows/docs.yml @eashaw
/.github/workflows/deploy-fleet-website.yml @eashaw
##############################################################################################
# 🚀 GitHub workflows
##############################################################################################
Add Tim to workflows codeowners (#27086)
2025-03-12 18:41:59 +00:00
/.github/workflows/ @lukeheath @georgekarrv @sharon-fdm @mostlikelee
Request review automatically for non-codeowners (#12786) https://github.com/fleetdm/confidential/issues/3146 To test this works: - sam should be able to change ceo handbook and be autoapproved - mike submitting a PR to the ceo handbook should request review from Sam but auto-approve for mike - Jarod's use case of creating an article should now work, even if his PR contains images . --------- Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
2023-07-16 00:56:30 +00:00
# ℹ️ But wait, there's more!
# See the comments up top to learn where else DRIs and maintainers are configured.
Reference in a new issue Copy permalink