From c744482b844e8d8068489267b9256b3e321cf495 Mon Sep 17 00:00:00 2001
From: Lucas Smith <me@lucasjamessmith.me>
Date: Mon, 11 Mar 2024 10:55:46 +1100
Subject: [PATCH] fix: add conditional to useEffects

---
 .../forms/2fa/enable-authenticator-app-dialog.tsx           | 6 ++++--
 .../src/components/forms/2fa/view-recovery-codes-dialog.tsx | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/apps/web/src/components/forms/2fa/enable-authenticator-app-dialog.tsx b/apps/web/src/components/forms/2fa/enable-authenticator-app-dialog.tsx
index cb4cd60e1..d7a8f6553 100644
--- a/apps/web/src/components/forms/2fa/enable-authenticator-app-dialog.tsx
+++ b/apps/web/src/components/forms/2fa/enable-authenticator-app-dialog.tsx
@@ -150,8 +150,10 @@ export const EnableAuthenticatorAppDialog = ({
   };
 
   useEffect(() => {
-    // Reset the form when the Dialog open state changes
-    setupTwoFactorAuthenticationForm.reset();
+    // Reset the form when the Dialog closes
+    if (!open) {
+      setupTwoFactorAuthenticationForm.reset();
+    }
   }, [open, setupTwoFactorAuthenticationForm]);
 
   return (
diff --git a/apps/web/src/components/forms/2fa/view-recovery-codes-dialog.tsx b/apps/web/src/components/forms/2fa/view-recovery-codes-dialog.tsx
index 2a83e6499..48e343e8d 100644
--- a/apps/web/src/components/forms/2fa/view-recovery-codes-dialog.tsx
+++ b/apps/web/src/components/forms/2fa/view-recovery-codes-dialog.tsx
@@ -93,8 +93,10 @@ export const ViewRecoveryCodesDialog = ({ open, onOpenChange }: ViewRecoveryCode
   };
 
   useEffect(() => {
-    // Reset the form when the Dialog open state changes
-    viewRecoveryCodesForm.reset();
+    // Reset the form when the Dialog closes
+    if (!open) {
+      viewRecoveryCodesForm.reset();
+    }
   }, [open, viewRecoveryCodesForm]);
 
   return (