(backend) Order pinned documents by last updated at

Sort favorite_list results by updated_at property descending.
    
Signed-off-by: Paul Vernin <paul.vernin@gmail.com>
This commit is contained in:
pvrn 2026-04-10 17:15:55 +02:00 committed by GitHub
parent 1ebdda8c9e
commit e652cdd040
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 50 additions and 2 deletions

View file

@ -8,7 +8,8 @@ and this project adheres to
### Fixed
🐛(frontend) abort check media status unmount #2194
- 🐛(frontend) abort check media status unmount #2194
- ✨(backend) order pinned documents by last updated at #2028
## [v4.8.6] - 2026-04-08

View file

@ -834,6 +834,7 @@ class DocumentViewSet(
queryset = self.queryset.filter(path_list)
queryset = queryset.filter(id__in=favorite_documents_ids)
queryset = queryset.filter(ancestors_deleted_at__isnull=True)
queryset = queryset.order_by("-updated_at")
queryset = queryset.annotate_user_roles(user)
queryset = queryset.annotate(
is_favorite=db.Value(True, output_field=db.BooleanField())

View file

@ -1,5 +1,9 @@
"""Test for the document favorite_list endpoint."""
from datetime import timedelta
from django.utils import timezone
import pytest
from rest_framework.test import APIClient
@ -111,8 +115,50 @@ def test_api_document_favorite_list_with_favorite_children():
content = response.json()["results"]
assert content[0]["id"] == str(children[0].id)
assert content[0]["id"] == str(access.document.id)
assert content[1]["id"] == str(children[1].id)
assert content[2]["id"] == str(children[0].id)
def test_api_document_favorite_list_sorted_by_updated_at():
"""
Authenticated users should receive their favorite documents including children
sorted by last updated_at timestamp.
"""
user = factories.UserFactory()
client = APIClient()
client.force_login(user)
root = factories.DocumentFactory(creator=user, users=[user])
children = factories.DocumentFactory.create_batch(
2, parent=root, favorited_by=[user]
)
access = factories.UserDocumentAccessFactory(
user=user, role=models.RoleChoices.READER, document__favorited_by=[user]
)
other_root = factories.DocumentFactory(creator=user, users=[user])
factories.DocumentFactory.create_batch(2, parent=other_root)
now = timezone.now()
models.Document.objects.filter(pk=children[0].pk).update(
updated_at=now + timedelta(seconds=2)
)
models.Document.objects.filter(pk=children[1].pk).update(
updated_at=now + timedelta(seconds=3)
)
response = client.get("/api/v1.0/documents/favorite_list/")
assert response.status_code == 200
assert response.json()["count"] == 3
content = response.json()["results"]
assert content[0]["id"] == str(children[1].id)
assert content[1]["id"] == str(children[0].id)
assert content[2]["id"] == str(access.document.id)