Elgato_dark/docs
1
0
Fork 0
mirror of https://github.com/suitenumerique/docs synced 2026-04-21 13:37:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

🐛(frontend) fix meta title

Browse source 
The meta title was flickering, it was adding the
doc title, then it was coming back to the default
title.
This was due to the way the next Head component
render data.
We now use a more stable way to set the title.
This commit is contained in:
Anthony LC 2025-05-30 12:39:59 +02:00
parent c5f018e03e
commit db63ebd0c8
No known key found for this signature in database
3 changed files with 17 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.md
View file

@ -20,6 +20,7 @@ and this project adheres to
-🐛(frontend) table of content disappearing #982
-🐛(frontend) fix multiple EmojiPicker #1012
-🐛(frontend) fix meta title #1017
## [3.3.0] - 2025-05-06

1
src/frontend/apps/impress/src/pages/_app.tsx
View file

@ -26,6 +26,7 @@ export default function App({ Component, pageProps }: AppPropsWithLayout) {
<>
<Head>
<title>{t('Docs')}</title>
<meta property="og:title" content={t('Docs')} key="title" />
<meta
name="description"
content={t(

24
src/frontend/apps/impress/src/pages/docs/[id]/index.tsx
View file

@ -67,14 +67,6 @@ const DocPage = ({ id }: DocProps) => {
useCollaboration(doc?.id, doc?.content);
const { t } = useTranslation();
useEffect(() => {
if (doc?.title) {
setTimeout(() => {
document.title = `${doc.title} - ${t('Docs')}`;
}, 100);
}
}, [doc?.title, t]);
useEffect(() => {
if (!docQuery || isFetching) {
return;
@ -142,7 +134,21 @@ const DocPage = ({ id }: DocProps) => {
);
}
return <DocEditor doc={doc} />;
return (
<>
<Head>
<title>
{doc.title} - {t('Docs')}
</title>
<meta
property="og:title"
content={`${doc.title} - ${t('Docs')}`}
key="title"
/>
</Head>
<DocEditor doc={doc} />
</>
);
};
const Page: NextPageWithLayout = () => {