From aed8ae7181b59d8f898e367d4e72f395fa544c28 Mon Sep 17 00:00:00 2001
From: Anthony LC <anthony.le-courric@mail.numerique.gouv.fr>
Date: Tue, 21 Apr 2026 11:05:07 +0200
Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B(frontend)=20remove=20horizontal=20?=
 =?UTF-8?q?line=20when=20no=20elements?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

When no elements are present in the doc share
modals, a horizontal line is still displayed.
This PR removes this line when there are no elements
to display.
---
 .../components/DocShareAccessRequest.tsx      | 33 +++++++++++-------
 .../components/DocShareInvitation.tsx         | 34 ++++++++++++-------
 .../doc-share/components/DocShareModal.tsx    |  2 --
 3 files changed, 42 insertions(+), 27 deletions(-)

diff --git a/src/frontend/apps/impress/src/features/docs/doc-share/components/DocShareAccessRequest.tsx b/src/frontend/apps/impress/src/features/docs/doc-share/components/DocShareAccessRequest.tsx
index 1354b4d4..2d77f9ba 100644
--- a/src/frontend/apps/impress/src/features/docs/doc-share/components/DocShareAccessRequest.tsx
+++ b/src/frontend/apps/impress/src/features/docs/doc-share/components/DocShareAccessRequest.tsx
@@ -11,6 +11,7 @@ import { createGlobalStyle, css } from 'styled-components';
 import {
   Box,
   BoxButton,
+  HorizontalSeparator,
   Icon,
   LoadMoreText,
   Loading,
@@ -165,19 +166,25 @@ export const QuickSearchGroupAccessRequest = ({
   }
 
   return (
-    <Box
-      aria-label={t('List request access card')}
-      className="--docs--share-access-request"
-      $padding={{ horizontal: 'base' }}
-    >
-      <QuickSearchGroupAccessRequestStyle />
-      <QuickSearchGroup
-        group={accessRequestsData}
-        renderElement={(accessRequest) => (
-          <DocShareAccessRequestItem doc={doc} accessRequest={accessRequest} />
-        )}
-      />
-    </Box>
+    <>
+      <Box
+        aria-label={t('List request access card')}
+        className="--docs--share-access-request"
+        $padding={{ horizontal: 'base' }}
+      >
+        <QuickSearchGroupAccessRequestStyle />
+        <QuickSearchGroup
+          group={accessRequestsData}
+          renderElement={(accessRequest) => (
+            <DocShareAccessRequestItem
+              doc={doc}
+              accessRequest={accessRequest}
+            />
+          )}
+        />
+      </Box>
+      <HorizontalSeparator $margin={{ vertical: 'sm' }} />
+    </>
   );
 };
 
diff --git a/src/frontend/apps/impress/src/features/docs/doc-share/components/DocShareInvitation.tsx b/src/frontend/apps/impress/src/features/docs/doc-share/components/DocShareInvitation.tsx
index e48b900f..d7f72df1 100644
--- a/src/frontend/apps/impress/src/features/docs/doc-share/components/DocShareInvitation.tsx
+++ b/src/frontend/apps/impress/src/features/docs/doc-share/components/DocShareInvitation.tsx
@@ -6,7 +6,14 @@ import { useMemo } from 'react';
 import { useTranslation } from 'react-i18next';
 import { css } from 'styled-components';
 
-import { Box, BoxButton, Icon, LoadMoreText, Text } from '@/components';
+import {
+  Box,
+  BoxButton,
+  HorizontalSeparator,
+  Icon,
+  LoadMoreText,
+  Text,
+} from '@/components';
 import { QuickSearchData, QuickSearchGroup } from '@/components/quick-search';
 import { useCunninghamTheme } from '@/cunningham';
 import { Doc, Role } from '@/docs/doc-management';
@@ -162,16 +169,19 @@ export const QuickSearchGroupInvitation = ({
   }
 
   return (
-    <Box
-      aria-label={t('List invitation card')}
-      $padding={{ horizontal: 'base' }}
-    >
-      <QuickSearchGroup
-        group={invitationsData}
-        renderElement={(invitation) => (
-          <DocShareInvitationItem doc={doc} invitation={invitation} />
-        )}
-      />
-    </Box>
+    <>
+      <Box
+        aria-label={t('List invitation card')}
+        $padding={{ horizontal: 'base' }}
+      >
+        <QuickSearchGroup
+          group={invitationsData}
+          renderElement={(invitation) => (
+            <DocShareInvitationItem doc={doc} invitation={invitation} />
+          )}
+        />
+      </Box>
+      <HorizontalSeparator $margin={{ vertical: 'sm' }} />
+    </>
   );
 };
diff --git a/src/frontend/apps/impress/src/features/docs/doc-share/components/DocShareModal.tsx b/src/frontend/apps/impress/src/features/docs/doc-share/components/DocShareModal.tsx
index 8d43218c..01f1c729 100644
--- a/src/frontend/apps/impress/src/features/docs/doc-share/components/DocShareModal.tsx
+++ b/src/frontend/apps/impress/src/features/docs/doc-share/components/DocShareModal.tsx
@@ -291,9 +291,7 @@ export const DocShareModal = ({ doc, onClose, isRootDoc = true }: Props) => {
                   {showMemberSection && isRootDoc && (
                     <Box $padding={{ top: 'base' }}>
                       <QuickSearchGroupAccessRequest doc={doc} />
-                      <HorizontalSeparator $margin={{ vertical: 'sm' }} />
                       <QuickSearchGroupInvitation doc={doc} />
-                      <HorizontalSeparator $margin={{ vertical: 'sm' }} />
                       <QuickSearchGroupMember doc={doc} />
                     </Box>
                   )}