From 67b9324c832b58852741e8872f8150fad0cbe251 Mon Sep 17 00:00:00 2001 From: Anthony LC Date: Mon, 20 Apr 2026 10:48:43 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B(frontend)=20fix=20app=20shalow=20r?= =?UTF-8?q?eload?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The app was doing a shalow reload when user was coming from another tab and the user data was staled. We stop to block the app during the loading state, depend the response the app will manage correctly its states. --- CHANGELOG.md | 11 ++++++----- .../impress/src/features/auth/components/Auth.tsx | 6 +----- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 98ae36b9..c6cd1d1d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,16 +6,17 @@ and this project adheres to ## [Unreleased] +### Changed + +- ♿️(frontend) structure correctly 5xx error alerts #2128 +- ♿️(frontend) make doc search result labels uniquely identifiable #2212 + ### Fixed - 🚸(frontend) redirect on current url tab after 401 #2197 - 🐛(frontend) abort check media status unmount #2194 - ✨(backend) order pinned documents by last updated at #2028 - -### Changed - -- ♿️(frontend) structure correctly 5xx error alerts #2128 -- ♿️(frontend) make doc search result labels uniquely identifiable #2212 +- 🐛(frontend) fix app shalow reload #2231 ## [v4.8.6] - 2026-04-08 diff --git a/src/frontend/apps/impress/src/features/auth/components/Auth.tsx b/src/frontend/apps/impress/src/features/auth/components/Auth.tsx index 178474ab..6987a334 100644 --- a/src/frontend/apps/impress/src/features/auth/components/Auth.tsx +++ b/src/frontend/apps/impress/src/features/auth/components/Auth.tsx @@ -20,7 +20,6 @@ export const Auth = ({ children }: PropsWithChildren) => { const { isLoading: isAuthLoading, pathAllowed, - isFetchedAfterMount, authenticated, fetchStatus, user, @@ -104,10 +103,7 @@ export const Auth = ({ children }: PropsWithChildren) => { ]); const shouldShowLoader = - (isLoading && !isFetchedAfterMount) || - isRedirecting || - (!authenticated && !pathAllowed) || - shouldTrySilentLogin; + isRedirecting || (!authenticated && !pathAllowed) || shouldTrySilentLogin; if (shouldShowLoader) { return ;