Elgato_dark/docs
1
0
Fork 0
mirror of https://github.com/suitenumerique/docs synced 2026-04-21 13:37:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

✨(frontend) update meta title for docs page

Browse source 
We update the meta title for the docs page
with the title of the document.
It will be easier for the user
to identify the document in their browser tab,
in their bookmarks and history.
This commit is contained in:
Anthony LC 2024-09-05 12:45:02 +02:00 committed by Anthony LC
parent 92102e4a36
commit 48d3738ec2
4 changed files with 18 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.md
View file

@ -14,6 +14,7 @@ and this project adheres to
- ✨Add image attachments with access control
- ✨(frontend) Upload image to a document #211
- ✨(frontend) Summary #223
- ✨(frontend) update meta title for docs page #231
## Changed

4
src/frontend/apps/e2e/__tests__/app-impress/doc-create.spec.ts
View file

@ -55,6 +55,10 @@ test.describe('Doc Create', () => {
true,
);
expect(await page.locator('title').textContent()).toMatch(
/My new doc - Docs/,
);
const header = page.locator('header').first();
await header.locator('h2').getByText('Docs').click();

7
src/frontend/apps/impress/src/pages/_app.tsx
View file

@ -21,7 +21,12 @@ export default function App({ Component, pageProps }: AppPropsWithLayout) {
<>
<Head>
<title>{t('Docs')}</title>
<meta name="description" content={t('Docs Description')} />
<meta
name="description"
content={t(
'Docs: Your new companion to collaborate on documents efficiently, intuitively, and securely.',
)}
/>
<link rel="icon" href="/favicon.ico" sizes="any" />
</Head>
<AppProvider>{getLayout(<Component {...pageProps} />)}</AppProvider>

7
src/frontend/apps/impress/src/pages/docs/[id]/index.tsx
View file

@ -1,6 +1,7 @@
import { Loader } from '@openfun/cunningham-react';
import { useRouter as useNavigate } from 'next/navigation';
import { useRouter } from 'next/router';
import { useEffect } from 'react';
import { Box, Text } from '@/components';
import { TextErrors } from '@/components/TextErrors';
@ -33,6 +34,12 @@ const DocPage = ({ id }: DocProps) => {
const { data: doc, isLoading, isError, error } = useDoc({ id });
const navigate = useNavigate();
useEffect(() => {
if (doc?.title) {
document.title = `${doc.title} - Docs`;
}
}, [doc?.title]);
if (isError && error) {
if (error.status === 404) {
navigate.replace(`/404`);