mirror of
https://github.com/datahaven-xyz/datahaven
synced 2026-05-24 09:50:01 +00:00
## Summary
### Configuration
- Remove deprecated `deny_warnings` config key from foundry.toml
- Add global `[lint]` config to suppress naming convention warnings for
AVS/EL/ERC patterns (`mixed-case-function`, `mixed-case-variable`)
### DataHavenServiceManager Refactoring
- Rename immutable variables to SCREAMING_SNAKE_CASE
(`_allocationManager` → `_ALLOCATION_MANAGER`, `_rewardsCoordinator` →
`_REWARDS_COORDINATOR`)
- Wrap modifier logic in internal functions (`_checkRewardsInitiator`,
`_checkValidator`, `_checkAllocationManager`) to reduce contract size
- Add `_toAddress` helper with assembly for safe bytes-to-address
conversion
### Safe Typecasting
- Replace direct typecasts with OpenZeppelin's SafeCast library in
deploy scripts and test utilities
- Use `.toUint32()`, `.toUint64()`, `.toUint160()` for
overflow-protected conversions
- Replace `bytes32("wrong origin")` string cast with hex literal in test
deployer
### Code Cleanup
- Remove 25+ unused imports across script and test files
- Convert plain imports to named imports for better clarity
- Use `SafeERC20.safeTransfer()` for token transfers in tests
- Change `view` to `pure` where appropriate
## Test plan
- [x] `forge build` completes with no warnings
- [x] `forge test` passes all 10 tests
254 lines
11 KiB
Solidity
254 lines
11 KiB
Solidity
// SPDX-License-Identifier: UNLICENSED
|
|
pragma solidity ^0.8.13;
|
|
|
|
/* solhint-disable func-name-mixedcase */
|
|
|
|
import {IERC20} from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
|
|
import {SafeERC20} from "@openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol";
|
|
import {
|
|
IRewardsCoordinatorTypes
|
|
} from "eigenlayer-contracts/src/contracts/interfaces/IRewardsCoordinator.sol";
|
|
|
|
import {AVSDeployer} from "./utils/AVSDeployer.sol";
|
|
import {ERC20FixedSupply} from "./utils/ERC20FixedSupply.sol";
|
|
import {IDataHavenServiceManagerEvents} from "../src/interfaces/IDataHavenServiceManager.sol";
|
|
|
|
contract RewardsSubmitterTest is AVSDeployer {
|
|
using SafeERC20 for IERC20;
|
|
|
|
// Test addresses
|
|
address public snowbridgeAgent = address(uint160(uint256(keccak256("snowbridgeAgent"))));
|
|
address public operator1 = address(uint160(uint256(keccak256("operator1"))));
|
|
address public operator2 = address(uint160(uint256(keccak256("operator2"))));
|
|
|
|
// Test token
|
|
ERC20FixedSupply public rewardToken;
|
|
|
|
// Constants aligned with test AVSDeployer's RewardsCoordinator setup (7 days)
|
|
uint32 public constant TEST_CALCULATION_INTERVAL = 7 days;
|
|
|
|
function setUp() public virtual {
|
|
_deployMockEigenLayerAndAVS();
|
|
|
|
// Deploy reward token
|
|
rewardToken = new ERC20FixedSupply("DataHaven", "HAVE", 1000000e18, address(this));
|
|
|
|
// Configure the rewards initiator
|
|
vm.prank(avsOwner);
|
|
serviceManager.setRewardsInitiator(snowbridgeAgent);
|
|
|
|
// Fund the service manager with reward tokens
|
|
IERC20(address(rewardToken)).safeTransfer(address(serviceManager), 100000e18);
|
|
}
|
|
|
|
// Helper function to build a submission
|
|
function _buildSubmission(
|
|
uint256 rewardAmount,
|
|
address operator
|
|
) internal view returns (IRewardsCoordinatorTypes.OperatorDirectedRewardsSubmission memory) {
|
|
IRewardsCoordinatorTypes.StrategyAndMultiplier[] memory strategiesAndMultipliers =
|
|
new IRewardsCoordinatorTypes.StrategyAndMultiplier[](deployedStrategies.length);
|
|
for (uint256 i = 0; i < deployedStrategies.length; i++) {
|
|
strategiesAndMultipliers[i] = IRewardsCoordinatorTypes.StrategyAndMultiplier({
|
|
strategy: deployedStrategies[i], multiplier: uint96((i + 1) * 1e18)
|
|
});
|
|
}
|
|
|
|
IRewardsCoordinatorTypes.OperatorReward[] memory operatorRewards =
|
|
new IRewardsCoordinatorTypes.OperatorReward[](1);
|
|
operatorRewards[0] =
|
|
IRewardsCoordinatorTypes.OperatorReward({operator: operator, amount: rewardAmount});
|
|
|
|
return IRewardsCoordinatorTypes.OperatorDirectedRewardsSubmission({
|
|
strategiesAndMultipliers: strategiesAndMultipliers,
|
|
token: IERC20(address(rewardToken)),
|
|
operatorRewards: operatorRewards,
|
|
startTimestamp: GENESIS_REWARDS_TIMESTAMP,
|
|
duration: TEST_CALCULATION_INTERVAL,
|
|
description: "DataHaven rewards"
|
|
});
|
|
}
|
|
|
|
// ============ Configuration Tests ============
|
|
|
|
function test_setRewardsInitiator() public {
|
|
address newInitiator = address(0x123);
|
|
|
|
vm.prank(avsOwner);
|
|
vm.expectEmit(true, true, false, false);
|
|
emit IDataHavenServiceManagerEvents.RewardsInitiatorSet(snowbridgeAgent, newInitiator);
|
|
serviceManager.setRewardsInitiator(newInitiator);
|
|
|
|
assertEq(serviceManager.rewardsInitiator(), newInitiator);
|
|
}
|
|
|
|
function test_setRewardsInitiator_revertsIfNotOwner() public {
|
|
vm.prank(operator1);
|
|
vm.expectRevert(bytes("Ownable: caller is not the owner"));
|
|
serviceManager.setRewardsInitiator(address(0x123));
|
|
}
|
|
|
|
// ============ Access Control Tests ============
|
|
|
|
function test_submitRewards_revertsIfNotRewardsInitiator() public {
|
|
IRewardsCoordinatorTypes.OperatorDirectedRewardsSubmission memory submission =
|
|
_buildSubmission(1000e18, operator1);
|
|
|
|
vm.prank(operator1);
|
|
vm.expectRevert(abi.encodeWithSignature("OnlyRewardsInitiator()"));
|
|
serviceManager.submitRewards(submission);
|
|
}
|
|
|
|
// ============ Success Tests ============
|
|
|
|
function test_submitRewards_singleOperator() public {
|
|
uint256 rewardAmount = 1000e18;
|
|
IRewardsCoordinatorTypes.OperatorDirectedRewardsSubmission memory submission =
|
|
_buildSubmission(rewardAmount, operator1);
|
|
|
|
// Warp to a time after the period ends
|
|
vm.warp(submission.startTimestamp + submission.duration + 1);
|
|
|
|
vm.prank(snowbridgeAgent);
|
|
vm.expectEmit(false, false, false, true);
|
|
emit IDataHavenServiceManagerEvents.RewardsSubmitted(rewardAmount, 1);
|
|
serviceManager.submitRewards(submission);
|
|
}
|
|
|
|
function test_submitRewards_multipleOperators() public {
|
|
// Build strategies
|
|
IRewardsCoordinatorTypes.StrategyAndMultiplier[] memory strategiesAndMultipliers =
|
|
new IRewardsCoordinatorTypes.StrategyAndMultiplier[](deployedStrategies.length);
|
|
for (uint256 i = 0; i < deployedStrategies.length; i++) {
|
|
strategiesAndMultipliers[i] = IRewardsCoordinatorTypes.StrategyAndMultiplier({
|
|
strategy: deployedStrategies[i], multiplier: uint96((i + 1) * 1e18)
|
|
});
|
|
}
|
|
|
|
// Ensure operators are sorted in ascending order (required by EigenLayer)
|
|
address opLow = address(0x1);
|
|
address opHigh = address(0x2);
|
|
|
|
uint256 amount1 = 600e18;
|
|
uint256 amount2 = 400e18;
|
|
uint256 totalAmount = amount1 + amount2;
|
|
|
|
IRewardsCoordinatorTypes.OperatorReward[] memory operatorRewards =
|
|
new IRewardsCoordinatorTypes.OperatorReward[](2);
|
|
operatorRewards[0] =
|
|
IRewardsCoordinatorTypes.OperatorReward({operator: opLow, amount: amount1});
|
|
operatorRewards[1] =
|
|
IRewardsCoordinatorTypes.OperatorReward({operator: opHigh, amount: amount2});
|
|
|
|
IRewardsCoordinatorTypes.OperatorDirectedRewardsSubmission memory submission =
|
|
IRewardsCoordinatorTypes.OperatorDirectedRewardsSubmission({
|
|
strategiesAndMultipliers: strategiesAndMultipliers,
|
|
token: IERC20(address(rewardToken)),
|
|
operatorRewards: operatorRewards,
|
|
startTimestamp: GENESIS_REWARDS_TIMESTAMP,
|
|
duration: TEST_CALCULATION_INTERVAL,
|
|
description: "DataHaven rewards"
|
|
});
|
|
|
|
// Warp to a time after the period ends
|
|
vm.warp(submission.startTimestamp + submission.duration + 1);
|
|
|
|
vm.prank(snowbridgeAgent);
|
|
vm.expectEmit(false, false, false, true);
|
|
emit IDataHavenServiceManagerEvents.RewardsSubmitted(totalAmount, 2);
|
|
serviceManager.submitRewards(submission);
|
|
}
|
|
|
|
function test_submitRewards_multipleSubmissions() public {
|
|
uint32 duration = TEST_CALCULATION_INTERVAL;
|
|
|
|
// Submit for period 0
|
|
IRewardsCoordinatorTypes.OperatorDirectedRewardsSubmission memory submission0 =
|
|
_buildSubmission(1000e18, operator1);
|
|
submission0.startTimestamp = GENESIS_REWARDS_TIMESTAMP;
|
|
vm.warp(submission0.startTimestamp + duration + 1);
|
|
vm.prank(snowbridgeAgent);
|
|
serviceManager.submitRewards(submission0);
|
|
|
|
// Submit for period 1
|
|
IRewardsCoordinatorTypes.OperatorDirectedRewardsSubmission memory submission1 =
|
|
_buildSubmission(1000e18, operator1);
|
|
submission1.startTimestamp = GENESIS_REWARDS_TIMESTAMP + duration;
|
|
vm.warp(submission1.startTimestamp + duration + 1);
|
|
vm.prank(snowbridgeAgent);
|
|
serviceManager.submitRewards(submission1);
|
|
|
|
// Submit for period 2
|
|
IRewardsCoordinatorTypes.OperatorDirectedRewardsSubmission memory submission2 =
|
|
_buildSubmission(1000e18, operator1);
|
|
submission2.startTimestamp = GENESIS_REWARDS_TIMESTAMP + 2 * duration;
|
|
vm.warp(submission2.startTimestamp + duration + 1);
|
|
vm.prank(snowbridgeAgent);
|
|
serviceManager.submitRewards(submission2);
|
|
}
|
|
|
|
function test_submitRewards_withCustomDescription() public {
|
|
// Build submission with custom description
|
|
IRewardsCoordinatorTypes.StrategyAndMultiplier[] memory strategiesAndMultipliers =
|
|
new IRewardsCoordinatorTypes.StrategyAndMultiplier[](1);
|
|
strategiesAndMultipliers[0] = IRewardsCoordinatorTypes.StrategyAndMultiplier({
|
|
strategy: deployedStrategies[0], multiplier: 1e18
|
|
});
|
|
|
|
IRewardsCoordinatorTypes.OperatorReward[] memory operatorRewards =
|
|
new IRewardsCoordinatorTypes.OperatorReward[](1);
|
|
operatorRewards[0] =
|
|
IRewardsCoordinatorTypes.OperatorReward({operator: operator1, amount: 1000e18});
|
|
|
|
IRewardsCoordinatorTypes.OperatorDirectedRewardsSubmission memory submission =
|
|
IRewardsCoordinatorTypes.OperatorDirectedRewardsSubmission({
|
|
strategiesAndMultipliers: strategiesAndMultipliers,
|
|
token: IERC20(address(rewardToken)),
|
|
operatorRewards: operatorRewards,
|
|
startTimestamp: GENESIS_REWARDS_TIMESTAMP,
|
|
duration: TEST_CALCULATION_INTERVAL,
|
|
description: "Era 42 validator rewards"
|
|
});
|
|
|
|
vm.warp(submission.startTimestamp + submission.duration + 1);
|
|
|
|
vm.prank(snowbridgeAgent);
|
|
serviceManager.submitRewards(submission);
|
|
}
|
|
|
|
function test_submitRewards_withDifferentToken() public {
|
|
// Deploy a different token
|
|
ERC20FixedSupply otherToken =
|
|
new ERC20FixedSupply("Other", "OTHER", 1000000e18, address(this));
|
|
IERC20(address(otherToken)).safeTransfer(address(serviceManager), 100000e18);
|
|
|
|
// Build submission with different token
|
|
IRewardsCoordinatorTypes.StrategyAndMultiplier[] memory strategiesAndMultipliers =
|
|
new IRewardsCoordinatorTypes.StrategyAndMultiplier[](1);
|
|
strategiesAndMultipliers[0] = IRewardsCoordinatorTypes.StrategyAndMultiplier({
|
|
strategy: deployedStrategies[0], multiplier: 1e18
|
|
});
|
|
|
|
IRewardsCoordinatorTypes.OperatorReward[] memory operatorRewards =
|
|
new IRewardsCoordinatorTypes.OperatorReward[](1);
|
|
operatorRewards[0] =
|
|
IRewardsCoordinatorTypes.OperatorReward({operator: operator1, amount: 500e18});
|
|
|
|
IRewardsCoordinatorTypes.OperatorDirectedRewardsSubmission memory submission =
|
|
IRewardsCoordinatorTypes.OperatorDirectedRewardsSubmission({
|
|
strategiesAndMultipliers: strategiesAndMultipliers,
|
|
token: IERC20(address(otherToken)),
|
|
operatorRewards: operatorRewards,
|
|
startTimestamp: GENESIS_REWARDS_TIMESTAMP,
|
|
duration: TEST_CALCULATION_INTERVAL,
|
|
description: "Bonus rewards in OTHER token"
|
|
});
|
|
|
|
vm.warp(submission.startTimestamp + submission.duration + 1);
|
|
|
|
vm.prank(snowbridgeAgent);
|
|
vm.expectEmit(false, false, false, true);
|
|
emit IDataHavenServiceManagerEvents.RewardsSubmitted(500e18, 1);
|
|
serviceManager.submitRewards(submission);
|
|
}
|
|
}
|