mirror of
https://github.com/datahaven-xyz/datahaven
synced 2026-05-24 09:50:01 +00:00
4d5716fdcb
## ⚠️ Breaking Changes ⚠️ Upgrades to SH version 0.2.0. Breaking changes for this version are outlined in the corresponding [release](https://github.com/Moonsong-Labs/storage-hub/releases/tag/v0.2.0). Particularly, in this PR, the following breaking changes are implemented for DH node operators: ### Breaking CLI changes vs `main` - **Fisherman vs provider role** - `--fisherman` now has `conflicts_with = "provider"` (`FishermanConfigurations::fisherman`). - Any existing scripts that started a node with both `--provider` and `--fisherman` will now fail clap validation. - **Removed / replaced fisherman tuning flags** - The following flags no longer exist and will cause errors if still used: - `--fisherman-incomplete-sync-max` (field `fisherman_incomplete_sync_max`) - `--fisherman-incomplete-sync-page-size` (field `fisherman_incomplete_sync_page_size`) - `--fisherman-sync-mode-min-blocks-behind` (field `fisherman_sync_mode_min_blocks_behind`) - They are replaced by: - `--fisherman-batch-interval-seconds` (`fisherman_batch_interval_seconds`, default `60`) - `--fisherman-batch-deletion-limit` (`fisherman_batch_deletion_limit`, default `1000`) - **MSP DB wiring no longer piggybacks on the indexer DB** - Previously, enabling the indexer (`IndexerConfigurations`) also wired its DB pool into the MSP move‑bucket path via `with_indexer_db_pool(maybe_indexer_db_pool)`. - Now, MSP DB access is **only** configured if you pass the new `--msp-database-url` provider flag; the indexer’s `--indexer` / `--indexer-database-url` no longer implicitly provide DB access to MSP logic. This will change behaviour for MSP nodes that relied on just the indexer flags. ### New / additive CLI flags (non‑breaking but behaviourally relevant) - **Provider flags** - `--pending-db-url` (`pending_db_url`, env `SH_PENDING_DB_URL`) for persisting pending extrinsics. - `--internal-buffer-size` (`internal_buffer_size`, default `1024`) for DB chunk batching during file transfer. - **Reordered but unchanged** - `--msp-distribute-files` still exists (bool flag), just moved within `ProviderConfigurations`; name and type are unchanged, but now also explicitly toggles `enable_msp_distribute_files` only when `provider_type == msp`. |
||
|---|---|---|
| .. | ||
| src | ||
| tests | ||
| build.rs | ||
| Cargo.toml | ||