mirror of
https://github.com/datahaven-xyz/datahaven
synced 2026-05-24 09:50:01 +00:00
## Summary Fixes the CI build failure in the `task-ts-build` workflow caused by Foundry v1.4.2's Solar linter not being able to resolve Snowbridge's context-specific import remappings. ## Problem The Snowbridge submodule uses context-specific remappings (prefixed with `:`) for its dependencies: - `lib/snowbridge/contracts/:openzeppelin/` → OpenZeppelin contracts - `lib/snowbridge/contracts/:prb/math/` → PRB Math library Foundry v1.4.2's Solar linter doesn't understand these context-specific remappings and fails with errors like: ``` error: file openzeppelin/utils/cryptography/MerkleProof.sol not found error: file prb/math/src/UD60x18.sol not found ``` ## Solution Added global remappings that the linter can understand: ```toml "openzeppelin/=lib/snowbridge/contracts/lib/openzeppelin-contracts/contracts/", "prb/math/=lib/snowbridge/contracts/lib/prb-math/", ``` ### Why This Works - The linter can now resolve `openzeppelin/` and `prb/math/` imports globally - These global remappings take **lower precedence** than context-specific ones during compilation - The compiler still uses the context-specific remappings (with `:`) when compiling Snowbridge contracts - The linter uses the global remappings when checking all files ## Changes ### Commit 1: Add global remappings - `contracts/foundry.toml`: Added 2 global remapping entries ### Commit 2: Apply forge fmt - Applied automatic formatting via `forge fmt` to ensure code style consistency - Multi-line formatting for long import statements and function signatures - No functional changes - purely formatting updates ## Testing ✅ Local build succeeds with `forge build` ✅ No Snowbridge import resolution errors ✅ `forge fmt --check` passes with no formatting issues ✅ Only linting notes/warnings remain (not errors) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude <noreply@anthropic.com>
294 lines
12 KiB
Solidity
294 lines
12 KiB
Solidity
// SPDX-License-Identifier: UNLICENSED
|
|
pragma solidity ^0.8.27;
|
|
|
|
import {DeployBase, ServiceManagerInitParams} from "./DeployBase.s.sol";
|
|
import {DataHavenServiceManager} from "../../src/DataHavenServiceManager.sol";
|
|
|
|
// Snowbridge imports for function signatures
|
|
import {BeefyClient} from "snowbridge/src/BeefyClient.sol";
|
|
import {AgentExecutor} from "snowbridge/src/AgentExecutor.sol";
|
|
import {IGatewayV2} from "snowbridge/src/v2/IGateway.sol";
|
|
|
|
// Logging import
|
|
import {Logging} from "../utils/Logging.sol";
|
|
|
|
// DataHaven imports for function signatures
|
|
import {VetoableSlasher} from "../../src/middleware/VetoableSlasher.sol";
|
|
import {RewardsRegistry} from "../../src/middleware/RewardsRegistry.sol";
|
|
|
|
// EigenLayer core contract imports for type casting
|
|
import {AllocationManager} from "eigenlayer-contracts/src/contracts/core/AllocationManager.sol";
|
|
import {AVSDirectory} from "eigenlayer-contracts/src/contracts/core/AVSDirectory.sol";
|
|
import {DelegationManager} from "eigenlayer-contracts/src/contracts/core/DelegationManager.sol";
|
|
import {RewardsCoordinator} from "eigenlayer-contracts/src/contracts/core/RewardsCoordinator.sol";
|
|
import {StrategyManager} from "eigenlayer-contracts/src/contracts/core/StrategyManager.sol";
|
|
import {IStrategy} from "eigenlayer-contracts/src/contracts/interfaces/IStrategy.sol";
|
|
import {
|
|
PermissionController
|
|
} from "eigenlayer-contracts/src/contracts/permissions/PermissionController.sol";
|
|
|
|
// OpenZeppelin imports for proxy creation
|
|
import {ProxyAdmin} from "@openzeppelin/contracts/proxy/transparent/ProxyAdmin.sol";
|
|
import {
|
|
TransparentUpgradeableProxy
|
|
} from "@openzeppelin/contracts/proxy/transparent/TransparentUpgradeableProxy.sol";
|
|
|
|
/**
|
|
* @title DeployTestnet
|
|
* @notice Deployment script for testnets (hoodi, holesky) - references existing EigenLayer contracts
|
|
*/
|
|
contract DeployTestnet is DeployBase {
|
|
// Supported testnet chains
|
|
enum TestnetChain {
|
|
HOODI,
|
|
HOLESKY
|
|
}
|
|
|
|
// Current testnet being deployed to
|
|
TestnetChain public currentTestnet;
|
|
string public networkName;
|
|
|
|
function run() public {
|
|
// Network detection and validation
|
|
networkName = vm.envString("NETWORK");
|
|
require(
|
|
bytes(networkName).length > 0,
|
|
"NETWORK environment variable required for testnet deployment"
|
|
);
|
|
|
|
currentTestnet = _detectAndValidateNetwork(networkName);
|
|
totalSteps = 2; // Reduced steps since we're not deploying EigenLayer
|
|
|
|
_executeSharedDeployment();
|
|
}
|
|
|
|
// Implementation of abstract functions from DeployBase
|
|
function _getNetworkName() internal view override returns (string memory) {
|
|
return networkName;
|
|
}
|
|
|
|
function _getDeploymentMode() internal view override returns (string memory) {
|
|
if (currentTestnet == TestnetChain.HOODI) {
|
|
return "HOODI_TESTNET";
|
|
} else if (currentTestnet == TestnetChain.HOLESKY) {
|
|
return "HOLESKY_TESTNET";
|
|
}
|
|
return "UNKNOWN_TESTNET";
|
|
}
|
|
|
|
function _setupEigenLayerContracts(
|
|
EigenLayerConfig memory config
|
|
) internal override returns (ProxyAdmin) {
|
|
Logging.logHeader("REFERENCING EXISTING EIGENLAYER CONTRACTS");
|
|
Logging.logSection(
|
|
string.concat("Referencing Existing EigenLayer Contracts on ", _getDeploymentMode())
|
|
);
|
|
|
|
// Reference existing EigenLayer contracts using addresses from config
|
|
delegation = DelegationManager(config.delegationManager);
|
|
strategyManager = StrategyManager(config.strategyManager);
|
|
avsDirectory = AVSDirectory(config.avsDirectory);
|
|
rewardsCoordinator = RewardsCoordinator(config.rewardsCoordinator);
|
|
allocationManager = AllocationManager(config.allocationManager);
|
|
permissionController = PermissionController(config.permissionController);
|
|
|
|
// Validate that contracts exist at the specified addresses
|
|
_validateContractExists(address(delegation), "DelegationManager");
|
|
_validateContractExists(address(strategyManager), "StrategyManager");
|
|
_validateContractExists(address(avsDirectory), "AVSDirectory");
|
|
_validateContractExists(address(rewardsCoordinator), "RewardsCoordinator");
|
|
_validateContractExists(address(allocationManager), "AllocationManager");
|
|
_validateContractExists(address(permissionController), "PermissionController");
|
|
|
|
Logging.logContractDeployed("DelegationManager (existing)", address(delegation));
|
|
Logging.logContractDeployed("StrategyManager (existing)", address(strategyManager));
|
|
Logging.logContractDeployed("AVSDirectory (existing)", address(avsDirectory));
|
|
Logging.logContractDeployed("RewardsCoordinator (existing)", address(rewardsCoordinator));
|
|
Logging.logContractDeployed("AllocationManager (existing)", address(allocationManager));
|
|
Logging.logContractDeployed(
|
|
"PermissionController (existing)", address(permissionController)
|
|
);
|
|
|
|
Logging.logStep("All EigenLayer contracts referenced successfully");
|
|
Logging.logFooter();
|
|
|
|
// Testnet deployments create their own ProxyAdmin (no existing one from EigenLayer deployment)
|
|
return ProxyAdmin(address(0)); // Will be created in _createServiceManagerProxy
|
|
}
|
|
|
|
function _createServiceManagerProxy(
|
|
DataHavenServiceManager implementation,
|
|
ProxyAdmin, // Ignored for testnet deployment
|
|
ServiceManagerInitParams memory params
|
|
) internal override returns (DataHavenServiceManager) {
|
|
// Testnet deployment creates its own ProxyAdmin for the service manager
|
|
vm.broadcast(_deployerPrivateKey);
|
|
ProxyAdmin proxyAdmin = new ProxyAdmin();
|
|
Logging.logContractDeployed("ProxyAdmin", address(proxyAdmin));
|
|
|
|
vm.broadcast(_deployerPrivateKey);
|
|
bytes memory initData = abi.encodeWithSelector(
|
|
DataHavenServiceManager.initialise.selector,
|
|
params.avsOwner,
|
|
params.rewardsInitiator,
|
|
params.validatorsStrategies,
|
|
new IStrategy[](0), // FIXME remove when BSPs and MSPs are removed
|
|
new IStrategy[](0), // FIXME remove when BSPs and MSPs are removed
|
|
params.gateway
|
|
);
|
|
|
|
TransparentUpgradeableProxy proxy =
|
|
new TransparentUpgradeableProxy(address(implementation), address(proxyAdmin), initData);
|
|
|
|
return DataHavenServiceManager(address(proxy));
|
|
}
|
|
|
|
function _outputDeployedAddresses(
|
|
BeefyClient beefyClient,
|
|
AgentExecutor agentExecutor,
|
|
IGatewayV2 gateway,
|
|
DataHavenServiceManager serviceManager,
|
|
DataHavenServiceManager serviceManagerImplementation,
|
|
VetoableSlasher vetoableSlasher,
|
|
RewardsRegistry rewardsRegistry,
|
|
address rewardsAgent
|
|
) internal override {
|
|
Logging.logHeader("DEPLOYMENT SUMMARY");
|
|
|
|
Logging.logSection("Snowbridge Contracts + Rewards Agent");
|
|
Logging.logContractDeployed("BeefyClient", address(beefyClient));
|
|
Logging.logContractDeployed("AgentExecutor", address(agentExecutor));
|
|
Logging.logContractDeployed("Gateway", address(gateway));
|
|
Logging.logContractDeployed("RewardsAgent", rewardsAgent);
|
|
|
|
Logging.logSection("DataHaven Contracts");
|
|
Logging.logContractDeployed("ServiceManager", address(serviceManager));
|
|
Logging.logContractDeployed("VetoableSlasher", address(vetoableSlasher));
|
|
Logging.logContractDeployed("RewardsRegistry", address(rewardsRegistry));
|
|
|
|
Logging.logSection(
|
|
string.concat("EigenLayer Core Contracts (Existing on ", _getDeploymentMode(), ")")
|
|
);
|
|
Logging.logContractDeployed("DelegationManager", address(delegation));
|
|
Logging.logContractDeployed("StrategyManager", address(strategyManager));
|
|
Logging.logContractDeployed("AVSDirectory", address(avsDirectory));
|
|
Logging.logContractDeployed("RewardsCoordinator", address(rewardsCoordinator));
|
|
Logging.logContractDeployed("AllocationManager", address(allocationManager));
|
|
Logging.logContractDeployed("PermissionController", address(permissionController));
|
|
|
|
Logging.logFooter();
|
|
|
|
// Write to deployment file for future reference
|
|
string memory network = _getNetworkName();
|
|
string memory deploymentPath =
|
|
string.concat(vm.projectRoot(), "/deployments/", network, ".json");
|
|
|
|
// Create directory if it doesn't exist
|
|
vm.createDir(string.concat(vm.projectRoot(), "/deployments"), true);
|
|
|
|
// Create JSON with deployed addresses
|
|
string memory json = "{";
|
|
json = string.concat(json, '"network": "', network, '",');
|
|
|
|
// Snowbridge contracts
|
|
json = string.concat(json, '"BeefyClient": "', vm.toString(address(beefyClient)), '",');
|
|
json = string.concat(json, '"AgentExecutor": "', vm.toString(address(agentExecutor)), '",');
|
|
json = string.concat(json, '"Gateway": "', vm.toString(address(gateway)), '",');
|
|
json =
|
|
string.concat(json, '"ServiceManager": "', vm.toString(address(serviceManager)), '",');
|
|
json = string.concat(
|
|
json,
|
|
'"ServiceManagerImplementation": "',
|
|
vm.toString(address(serviceManagerImplementation)),
|
|
'",'
|
|
);
|
|
json = string.concat(
|
|
json, '"VetoableSlasher": "', vm.toString(address(vetoableSlasher)), '",'
|
|
);
|
|
json = string.concat(
|
|
json, '"RewardsRegistry": "', vm.toString(address(rewardsRegistry)), '",'
|
|
);
|
|
json = string.concat(json, '"RewardsAgent": "', vm.toString(rewardsAgent), '",');
|
|
|
|
// EigenLayer contracts (existing on testnet)
|
|
json = string.concat(json, '"DelegationManager": "', vm.toString(address(delegation)), '",');
|
|
json = string.concat(
|
|
json, '"StrategyManager": "', vm.toString(address(strategyManager)), '",'
|
|
);
|
|
json = string.concat(json, '"AVSDirectory": "', vm.toString(address(avsDirectory)), '",');
|
|
json = string.concat(
|
|
json, '"RewardsCoordinator": "', vm.toString(address(rewardsCoordinator)), '",'
|
|
);
|
|
json = string.concat(
|
|
json, '"AllocationManager": "', vm.toString(address(allocationManager)), '",'
|
|
);
|
|
json = string.concat(
|
|
json, '"PermissionController": "', vm.toString(address(permissionController)), '"'
|
|
);
|
|
|
|
json = string.concat(json, "}");
|
|
|
|
// Write to file
|
|
vm.writeFile(deploymentPath, json);
|
|
Logging.logInfo(string.concat("Deployment info saved to: ", deploymentPath));
|
|
}
|
|
|
|
// TESTNET-SPECIFIC FUNCTIONS
|
|
|
|
/**
|
|
* @notice Detect and validate the target testnet network
|
|
*/
|
|
function _detectAndValidateNetwork(
|
|
string memory network
|
|
) internal pure returns (TestnetChain) {
|
|
bytes32 networkHash = keccak256(abi.encodePacked(network));
|
|
|
|
if (networkHash == keccak256(abi.encodePacked("hoodi"))) {
|
|
return TestnetChain.HOODI;
|
|
} else if (networkHash == keccak256(abi.encodePacked("holesky"))) {
|
|
return TestnetChain.HOLESKY;
|
|
}
|
|
|
|
revert(
|
|
string.concat(
|
|
"Unsupported testnet network: ", network, ". Supported networks: hoodi, holesky"
|
|
)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @notice Validate that a contract exists at the given address
|
|
*/
|
|
function _validateContractExists(
|
|
address contractAddress,
|
|
string memory contractName
|
|
) internal view {
|
|
require(
|
|
contractAddress != address(0), string.concat(contractName, " address cannot be zero")
|
|
);
|
|
|
|
uint256 codeSize;
|
|
assembly {
|
|
codeSize := extcodesize(contractAddress)
|
|
}
|
|
require(
|
|
codeSize > 0,
|
|
string.concat(
|
|
"No contract found at ", contractName, " address: ", vm.toString(contractAddress)
|
|
)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @notice Get testnet-specific configuration parameters
|
|
* @dev Override this function to add testnet-specific logic in the future
|
|
*/
|
|
function _getTestnetConfig() internal view returns (string memory) {
|
|
if (currentTestnet == TestnetChain.HOODI) {
|
|
return "hoodi";
|
|
} else if (currentTestnet == TestnetChain.HOLESKY) {
|
|
return "holesky";
|
|
}
|
|
return "unknown";
|
|
}
|
|
}
|