Elgato_dark/datahaven
1
0
Fork 0
mirror of https://github.com/datahaven-xyz/datahaven synced 2026-05-24 01:38:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: 🩹 add mandatory extrinsics to safe mode whitelisted calls (#265)

Browse source 
# Fix: Safe Mode Whitelisted Calls - enable block production

## Problem
The safe mode whitelist was missing critical runtime calls needed for
block production, generating this error:

```
2025-10-29 17:29:48 Proposing failed: Import failed: Extrinsic is not valid: TransactionValidityError::Invalid(InvalidTransaction::BadMandatory)
```

The SafeMode filter needs to include all RuntimeCalls that have
inherents marked as `DispatchClass::Mandatory`, as you can see
[here](bbc435c766/substrate/frame/executive/src/lib.rs (L806)).

If a single inherent is missing the whole block will not be valid,
causing the chain to stall.

## Solution
Bisect all the calls to find the culprit, until find it was the pallet
Randomness. I included it in `SafeModeWhitelistedCalls` and blocks are
being produced in SafeMode.
This commit is contained in:
Gonza Montiel 2025-10-30 09:38:18 +01:00 committed by GitHub
parent 7c8227f1ab
commit e079cdc404
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
operator/runtime/mainnet/src/configs/mod.rs
View file

@ -236,7 +236,7 @@ impl Contains<RuntimeCall> for NormalCallFilter {
}
/// Calls that can bypass the safe-mode pallet.
/// These calls are essential for emergency governance and system maintenance.
/// These calls are essential for emergency governance, system maintenance, and basic operation.
pub struct SafeModeWhitelistedCalls;
impl Contains<RuntimeCall> for SafeModeWhitelistedCalls {
fn contains(call: &RuntimeCall) -> bool {
@ -257,6 +257,8 @@ impl Contains<RuntimeCall> for SafeModeWhitelistedCalls {
RuntimeCall::Referenda(_) => true,
RuntimeCall::TechnicalCommittee(_) => true,
RuntimeCall::TreasuryCouncil(_) => true,
// Block production - needed to continue producing blocks in safe mode
RuntimeCall::Randomness(_) => true,
_ => false,
}
}

4
operator/runtime/stagenet/src/configs/mod.rs
View file

@ -236,7 +236,7 @@ impl Contains<RuntimeCall> for NormalCallFilter {
}
/// Calls that can bypass the safe-mode pallet.
/// These calls are essential for emergency governance and system maintenance.
/// These calls are essential for emergency governance, system maintenance, and basic operation.
pub struct SafeModeWhitelistedCalls;
impl Contains<RuntimeCall> for SafeModeWhitelistedCalls {
fn contains(call: &RuntimeCall) -> bool {
@ -257,6 +257,8 @@ impl Contains<RuntimeCall> for SafeModeWhitelistedCalls {
RuntimeCall::Referenda(_) => true,
RuntimeCall::TechnicalCommittee(_) => true,
RuntimeCall::TreasuryCouncil(_) => true,
// Block production - needed to continue producing blocks in safe mode
RuntimeCall::Randomness(_) => true,
_ => false,
}
}

4
operator/runtime/testnet/src/configs/mod.rs
View file

@ -236,7 +236,7 @@ impl Contains<RuntimeCall> for NormalCallFilter {
}
/// Calls that can bypass the safe-mode pallet.
/// These calls are essential for emergency governance and system maintenance.
/// These calls are essential for emergency governance, system maintenance, and basic operation.
pub struct SafeModeWhitelistedCalls;
impl Contains<RuntimeCall> for SafeModeWhitelistedCalls {
fn contains(call: &RuntimeCall) -> bool {
@ -257,6 +257,8 @@ impl Contains<RuntimeCall> for SafeModeWhitelistedCalls {
RuntimeCall::Referenda(_) => true,
RuntimeCall::TechnicalCommittee(_) => true,
RuntimeCall::TreasuryCouncil(_) => true,
// Block production - needed to continue producing blocks in safe mode
RuntimeCall::Randomness(_) => true,
_ => false,
}
}