(processVariables: true) do not collect input if variable is missing (#456)

.changeset/slow-pets-scream.md

@@ -0,0 +1,5 @@
+---
+'@graphql-hive/client': patch
+---
+
+(processVariables: true) do not collect input when corresponding variable is missing

packages/libraries/client/src/internal/usage.ts

@@ -318,8 +318,8 @@ export function createCollector({
               }
             }
           } else {
-            // Collect the entire type
-            collectInputType(namedType.name);
+            // Collect type without fields
+            markAsUsed(makeId(namedType.name));
           }
         });
       } else {

packages/libraries/client/tests/usage-collector.spec.ts

@@ -336,6 +336,32 @@ test('(processVariables: true) collect used-only input fields', async () => {
   expect(info.fields).not.toContain(`PaginationInput.offset`);
 });
 
+test('(processVariables: true) should collect input object without fields when corresponding variable is not provided', async () => {
+  const collect = createCollector({
+    schema,
+    max: 1,
+    processVariables: true,
+  });
+  const info = collect(
+    parse(/* GraphQL */ `
+      query getProjects($pagination: PaginationInput, $type: ProjectType!) {
+        projects(filter: { pagination: $pagination, type: $type }) {
+          id
+        }
+      }
+    `),
+    {
+      type: 'STITCHING',
+    }
+  ).value;
+
+  expect(info.fields).toContain(`FilterInput.type`);
+  expect(info.fields).toContain(`FilterInput.pagination`);
+  expect(info.fields).toContain(`PaginationInput`);
+  expect(info.fields).not.toContain(`PaginationInput.limit`);
+  expect(info.fields).not.toContain(`PaginationInput.offset`);
+});
+
 test('(processVariables: true) collect used-only input type fields from an array', async () => {
   const collect = createCollector({
     schema,

packages/web/app/src/components/target/explorer/common.tsx

@@ -134,6 +134,8 @@ export function GraphQLTypeCard(
     name: string;
     description?: string | null;
     implements?: string[];
+    totalRequests?: number;
+    usage?: DocumentType<typeof SchemaExplorerUsageStats_UsageFragment>;
   }>
 ) {
   return (
@@ -156,6 +158,9 @@ export function GraphQLTypeCard(
             </div>
           </div>
         ) : null}
+        {props.usage && typeof props.totalRequests !== 'undefined' ? (
+          <SchemaExplorerUsageStats totalRequests={props.totalRequests} usage={props.usage} />
+        ) : null}
       </div>
       <div>{props.children}</div>
     </div>

packages/web/app/src/components/target/explorer/input-object-type.tsx

@@ -19,7 +19,13 @@ export function GraphQLInputObjectTypeComponent(props: {
   totalRequests: number;
 }) {
   return (
-    <GraphQLTypeCard kind="input" name={props.type.name} description={props.type.description}>
+    <GraphQLTypeCard
+      kind="input"
+      name={props.type.name}
+      description={props.type.description}
+      totalRequests={props.totalRequests}
+      usage={props.type.usage}
+    >
       <GraphQLInputFields fields={props.type.fields} totalRequests={props.totalRequests} />
     </GraphQLTypeCard>
   );