Elgato_dark/console
1
0
Fork 0
mirror of https://github.com/graphql-hive/console synced 2026-05-24 09:38:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Set higher timeout when calling external composition service (#1362)

Browse source
This commit is contained in:
Kamil Kisiela 2023-02-13 17:08:57 +01:00 committed by GitHub
parent ce1d75d4d7
commit e87880079d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
packages/services/schema/src/cache.ts
View file

@ -73,6 +73,7 @@ export function createCache(options: {
}
return {
timeoutMs,
reuse<I, O>(groupKey: string, factory: (input: I) => Promise<O>): (input: I) => Promise<O> {
async function reuseFactory(input: I, attempt = 0): Promise<O> {
const id = `${prefix}:${groupKey}:${createChecksum(input)}`;

11
packages/services/schema/src/orchestrators.ts
View file

@ -212,6 +212,7 @@ async function callExternalServiceViaBroker(
},
payload: BrokerPayload,
logger: FastifyLoggerInstance,
timeoutMs: number,
) {
return callExternalService(
{
@ -224,12 +225,14 @@ async function callExternalServiceViaBroker(
body: JSON.stringify(payload),
},
logger,
timeoutMs,
);
}
async function callExternalService(
input: { url: string; headers: Record<string, string>; body: string },
logger: FastifyLoggerInstance,
timeoutMs: number,
) {
try {
const response = await got(input.url, {
@ -243,7 +246,7 @@ async function callExternalService(
backoffLimit: 500,
},
timeout: {
request: 10_000,
request: timeoutMs,
},
});
@ -251,7 +254,7 @@ async function callExternalService(
} catch (error) {
if (error instanceof RequestError) {
if (error.response) {
const message = error.response.body ? error.response.body : error.response.statusMessage; // await res.text().catch(_ => Promise.resolve(res.statusText));
const message = error.response.body ? error.response.body : error.response.statusMessage;
// If the response is a string starting with ERR_ it's a special error returned by the composition service.
// We don't want to throw an error in this case, but instead return a failure result.
@ -301,6 +304,7 @@ const createFederation: (
logger: FastifyLoggerInstance,
decrypt: (value: string) => string,
) => Orchestrator = (cache, logger, decrypt) => {
const timeoutMs = Math.min(cache.timeoutMs, 25_000);
const compose = cache.reuse<
{
schemas: ValidationInput | SupergraphInput;
@ -349,8 +353,9 @@ const createFederation: (
...request,
},
logger,
timeoutMs,
)
: callExternalService(request, logger)),
: callExternalService(request, logger, timeoutMs)),
);
if (!parseResult.success) {