Elgato_dark/console
1
0
Fork 0
mirror of https://github.com/graphql-hive/console synced 2026-05-23 09:08:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix: skip visiting directive arguments when collecting usage (#1224)

Browse source
This commit is contained in:
Ryan Perry-Nguyen 2023-02-10 06:52:53 -05:00 committed by GitHub
parent de7ba835e4
commit cf14c18d6e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 39 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/many-jobs-perform.md Normal file
View file

@ -0,0 +1,5 @@
---
'@graphql-hive/client': minor
---
skip directive arguments during usage collection

6
packages/libraries/client/src/internal/usage.ts
View file

@ -379,6 +379,12 @@ export function createCollector({
collectInputType(resolveTypeName(inputType));
}
},
Directive(node) {
return {
...node,
arguments: [],
};
},
Argument(node) {
const parent = typeInfo.getParentType()!;
const field = typeInfo.getFieldDef()!;

28
packages/libraries/client/tests/usage-collector.spec.ts
View file

@ -195,6 +195,34 @@ test('collect arguments', async () => {
expect(info.fields).toContain(`Query.projects.filter`);
});
test('skips argument directives', async () => {
const collect = createCollector({
schema,
max: 1,
});
const info = collect(
parse(/* GraphQL */ `
query getProjects($limit: Int!, $type: ProjectType!, $includeName: Boolean!) {
projects(filter: { pagination: { limit: $limit }, type: $type }) {
id
...NestedFragment
}
}
fragment NestedFragment on Project {
...IncludeNameFragment @include(if: $includeName)
}
fragment IncludeNameFragment on Project {
name
}
`),
{},
).value;
expect(info.fields).toContain(`Query.projects.filter`);
});
test('collect used-only input fields', async () => {
const collect = createCollector({
schema,