Elgato_dark/console
1
0
Fork 0
mirror of https://github.com/graphql-hive/console synced 2026-05-23 09:08:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix: typescript exclamation mark (#4090)

Browse source
This commit is contained in:
Laurin Quast 2024-02-26 23:37:13 +01:00 committed by GitHub
parent b6c1a6327d
commit c7abf7ceb0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 9 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/services/api/src/modules/schema/providers/models/composite-legacy.ts
View file

@ -184,8 +184,8 @@ export class CompositeLegacyModel {
commit: input.commit,
target: target.id,
date: Date.now() as any,
service_name: input.service!,
service_url: input.url!,
service_name: input.service || '',
service_url: input.url || '',
action: 'PUSH',
metadata: input.metadata ?? null,
};
@ -327,8 +327,8 @@ export class CompositeLegacyModel {
if (shouldBePublished) {
const messages: string[] = [];
if (hasNewUrl) {
messages.push(serviceUrlCheck.result.message!);
if (serviceUrlCheck.status === 'completed' && serviceUrlCheck.result.status === 'modified') {
messages.push(serviceUrlCheck.result.message);
}
if (hasNewMetadata) {

15
packages/services/api/src/modules/schema/providers/models/composite.ts
View file

@ -308,8 +308,8 @@ export class CompositeModel {
commit: input.commit,
target: target.id,
date: Date.now() as any,
service_name: input.service!,
service_url: input.url!,
service_name: input.service || '',
service_url: input.url || '',
action: 'PUSH',
metadata: input.metadata ?? null,
};
@ -456,18 +456,13 @@ export class CompositeModel {
conditionalBreakingChangeDiffConfig,
});
const hasNewUrl =
serviceUrlCheck.status === 'completed' && serviceUrlCheck.result.status === 'modified';
const hasNewMetadata =
metadataCheck?.status === 'completed' && metadataCheck.result.status === 'modified';
const messages: string[] = [];
if (hasNewUrl) {
messages.push(serviceUrlCheck.result.message!);
if (serviceUrlCheck.status === 'completed' && serviceUrlCheck.result.status === 'modified') {
messages.push(serviceUrlCheck.result.message);
}
if (hasNewMetadata) {
if (metadataCheck?.status === 'completed' && metadataCheck.result.status === 'modified') {
messages.push('Metadata has been updated');
}