Elgato_dark/console
1
0
Fork 0
mirror of https://github.com/graphql-hive/console synced 2026-05-23 09:08:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

safer lookup based on object identity (#4167)

Browse source
This commit is contained in:
Laurin Quast 2024-03-06 17:40:13 +01:00 committed by GitHub
parent 0692c2cb3c
commit c2cd0d9b93
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/services/api/src/modules/schema/providers/breaking-schema-changes-helper.ts
View file

@ -11,8 +11,8 @@ import { formatNumber, formatPercentage } from '../lib/number-formatting';
export class BreakingSchemaChangeUsageHelper {
constructor() {}
private breakingSchemaChangeToUsageMap = new Map<
string,
private breakingSchemaChangeToUsageMap = new WeakMap<
SchemaChangeType,
ConditionalBreakingChangeMetadata['usage']
>();
@ -20,7 +20,7 @@ export class BreakingSchemaChangeUsageHelper {
schemaChange: SchemaChangeType,
usage: ConditionalBreakingChangeMetadata['usage'],
) {
this.breakingSchemaChangeToUsageMap.set(schemaChange.id, usage);
this.breakingSchemaChangeToUsageMap.set(schemaChange, usage);
}
async getUsageDataForBreakingSchemaChange(schemaChange: SchemaChangeType) {
@ -28,7 +28,7 @@ export class BreakingSchemaChangeUsageHelper {
return null;
}
const usageData = this.breakingSchemaChangeToUsageMap.get(schemaChange.id);
const usageData = this.breakingSchemaChangeToUsageMap.get(schemaChange);
if (usageData == null) {
return null;