Elgato_dark/console
1
0
Fork 0
mirror of https://github.com/graphql-hive/console synced 2026-05-23 00:58:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Use Histogram instead of Summary for durations (#455)

Browse source
This commit is contained in:
Kamil Kisiela 2022-10-05 14:09:56 +02:00 committed by GitHub
parent dc78518241
commit 97cf8a672e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 16 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
packages/services/usage-ingestor/src/ingestor.ts
View file

@ -2,7 +2,6 @@ import { Kafka, KafkaMessage, logLevel } from 'kafkajs';
import { decompress } from '@hive/usage-common';
import {
errors,
processTime,
processDuration,
reportMessageBytes,
ingestedOperationsWrites,
@ -150,8 +149,7 @@ export function createIngestor(config: {
autoCommitThreshold: 2,
partitionsConsumedConcurrently: config.kafka.concurrency,
eachMessage({ message }) {
const stopTimer = processTime.startTimer();
const processDurationStop = processDuration.startTimer();
const stopTimer = processDuration.startTimer();
return processMessage({
message,
logger,
@ -164,7 +162,6 @@ export function createIngestor(config: {
})
.finally(() => {
stopTimer();
processDurationStop();
});
},
});

5
packages/services/usage-ingestor/src/metrics.ts
View file

@ -15,11 +15,6 @@ export const totalOperations = new metrics.Counter({
help: 'Number of raw operations received by usage ingestor service',
});
export const processTime = new metrics.Summary({
name: 'usage_ingestor_process_time',
help: 'Time spent processing and writing reports',
});
export const processDuration = new metrics.Histogram({
name: 'usage_ingestor_process_duration_seconds',
help: 'Time spent processing and writing reports',

4
packages/services/usage/src/index.ts
View file

@ -8,7 +8,7 @@ import {
httpRequestsWithoutToken,
httpRequestsWithNonExistingToken,
httpRequestsWithNoAccess,
collectLatency,
collectDuration,
droppedReports,
} from './metrics';
import type { IncomingLegacyReport, IncomingReport } from './types';
@ -124,7 +124,7 @@ async function main() {
const retentionInfo = (await rateLimit?.getRetentionForTargetId?.(tokenInfo.target)) || null;
const stopTimer = collectLatency.startTimer();
const stopTimer = collectDuration.startTimer();
try {
await collect(req.body, tokenInfo, retentionInfo);
stopTimer();

18
packages/services/usage/src/metrics.ts
View file

@ -66,19 +66,19 @@ export const invalidRawOperations = new metrics.Counter({
help: 'Number of invalid raw operations dropped by usage service',
});
export const collectLatency = new metrics.Summary({
name: 'usage_raw_collect_latency',
help: 'Collect latency',
export const collectDuration = new metrics.Histogram({
name: 'usage_raw_collect_duration_seconds',
help: 'Collect duration in seconds',
});
export const compressLatency = new metrics.Summary({
name: 'usage_raw_compress_latency',
help: 'Compress latency',
export const compressDuration = new metrics.Histogram({
name: 'usage_raw_compress_duration_seconds',
help: 'Compress duration in seconds',
});
export const kafkaLatency = new metrics.Summary({
name: 'usage_raw_kafka_latency',
help: 'Kafka latency',
export const kafkaDuration = new metrics.Histogram({
name: 'usage_raw_kafka_duration_seconds',
help: 'Kafka duration in seconds',
});
export const bufferFlushes = new metrics.Counter({

8
packages/services/usage/src/usage.ts
View file

@ -9,8 +9,8 @@ import {
totalOperations,
totalReports,
totalLegacyReports,
kafkaLatency,
compressLatency,
kafkaDuration,
compressDuration,
bufferFlushes,
estimationError,
} from './metrics';
@ -168,11 +168,11 @@ export function createUsage(config: {
async sender(reports, estimatedSizeInBytes, batchId, validateSize) {
const numOfOperations = reports.reduce((sum, report) => report.size + sum, 0);
try {
const compressLatencyStop = compressLatency.startTimer();
const compressLatencyStop = compressDuration.startTimer();
const value = await compress(JSON.stringify(reports)).finally(() => {
compressLatencyStop();
});
const stopTimer = kafkaLatency.startTimer();
const stopTimer = kafkaDuration.startTimer();
estimationError.observe(Math.abs(estimatedSizeInBytes - value.byteLength) / value.byteLength);