From 80ccca590f73eb4f4f4709f652d212292a817077 Mon Sep 17 00:00:00 2001 From: Kamil Kisiela Date: Thu, 5 Jan 2023 19:28:07 +0100 Subject: [PATCH] Fix target's name in GitHub schema:check (#957) --- .../src/modules/schema/providers/schema-publisher.ts | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/packages/services/api/src/modules/schema/providers/schema-publisher.ts b/packages/services/api/src/modules/schema/providers/schema-publisher.ts index 8eec8475b..d5efe8eeb 100644 --- a/packages/services/api/src/modules/schema/providers/schema-publisher.ts +++ b/packages/services/api/src/modules/schema/providers/schema-publisher.ts @@ -83,7 +83,12 @@ export class SchemaPublisher { scope: TargetAccessScope.REGISTRY_READ, }); - const [project, latest] = await Promise.all([ + const [target, project, latest] = await Promise.all([ + this.targetManager.getTarget({ + organization: input.organization, + project: input.project, + target: input.target, + }), this.projectManager.getProject({ organization: input.organization, project: input.project, @@ -117,7 +122,7 @@ export class SchemaPublisher { try { await this.gitHubIntegrationManager.createCheckRun({ - name: 'GraphQL Hive - schema:check', + name: buildGitHubActionCheckName(target.name, null), conclusion: 'failure', sha: input.github.commit, organization: input.organization, @@ -225,7 +230,7 @@ export class SchemaPublisher { } await this.gitHubIntegrationManager.createCheckRun({ - name: buildGitHubActionCheckName(input.target, input.service ?? null), + name: buildGitHubActionCheckName(target.name, input.service ?? null), conclusion: validationResult.valid ? 'success' : 'failure', sha: input.github.commit, organization: input.organization,