Elgato_dark/console
1
0
Fork 0
mirror of https://github.com/graphql-hive/console synced 2026-04-21 14:37:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix: properly link github check-run to hive schema check (#3406)

Browse source
This commit is contained in:
Laurin Quast 2023-11-16 16:16:56 +01:00 committed by GitHub
parent f07d84731c
commit 7d8ec3fc81
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
docs/DEVELOPMENT.md
View file

@ -122,11 +122,13 @@ We recommend the following flow if you are having issues with running Hive local
```
INTEGRATION_GITHUB=1
INTEGRATION_GITHUB_GITHUB_APP_ID=<your-github-app-id>
INTEGRATION_GITHUB_GITHUB_APP_PRIVATE_KEY=<your-github-app-private-key>
```
You'll find the GitHub App ID and private key in the `General` tab of your GitHub App.
Store the Github private key next to the `.env` file with the name `github-app.pem`
(`packages/services/server/github-app.pem`)
2. Web App: Set the following in `packages/web/app/.env`:
```
INTEGRATION_GITHUB_APP_NAME=<your-github-app-name>

2
packages/services/api/src/modules/integrations/providers/github-integration-manager.ts
View file

@ -314,7 +314,7 @@ export class GitHubIntegrationManager {
check_run_id: args.githubCheckRun.id,
conclusion: args.conclusion,
output: args.output,
detailsUrl: args.detailsUrl ?? undefined,
details_url: args.detailsUrl ?? undefined,
});
this.logger.debug('Check-run updated (link=%s)', result.data.url);