Elgato_dark/console
1
0
Fork 0
mirror of https://github.com/graphql-hive/console synced 2026-05-23 17:18:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix: broken tab indicator (#5201)

Browse source
This commit is contained in:
Laurin Quast 2024-07-11 14:58:35 +02:00 committed by GitHub
parent 0f99a20af2
commit 7aa919e58c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 14 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/web/app/src/components/v2/diff-editor.tsx
View file

@ -46,7 +46,7 @@ export const DiffEditor = (props: {
<div className="mr-2 text-xs font-normal">Navigate changes </div>
<TooltipProvider>
<Tooltip>
<TooltipTrigger>
<TooltipTrigger asChild>
<Button
variant="ghost"
size="icon-sm"
@ -58,7 +58,7 @@ export const DiffEditor = (props: {
<TooltipContent>Previous change</TooltipContent>
</Tooltip>
<Tooltip>
<TooltipTrigger>
<TooltipTrigger asChild>
<Button
variant="ghost"
size="icon-sm"
@ -129,7 +129,7 @@ function DownloadButton(props: { contents: string; fileName: string }) {
return (
<TooltipProvider>
<Tooltip>
<TooltipTrigger>
<TooltipTrigger asChild>
<Button
variant="ghost"
size="sm"

21
packages/web/app/src/pages/target-history-version.tsx
View file

@ -283,13 +283,12 @@ function DefaultSchemaVersionView(props: {
<TabsList className="bg-background border-muted w-full justify-start rounded-none border-x border-b">
{availableViews.map(item => (
<Tooltip key={item.value}>
<TooltipTrigger
// fixes <button> cannot appear as a descendant of <button>
asChild
>
<TabsTrigger value={item.value} disabled={!!item.disabledReason}>
{item.icon}
<span className="ml-2">{item.label}</span>
<TooltipTrigger>
<TabsTrigger value={item.value} disabled={!!item.disabledReason} asChild>
<span>
{item.icon}
<span className="ml-2">{item.label}</span>
</span>
</TabsTrigger>
</TooltipTrigger>
{item.disabledReason && (
@ -457,9 +456,11 @@ function ContractVersionView(props: {
{availableViews.map(item => (
<Tooltip key={item.value}>
<TooltipTrigger>
<TabsTrigger value={item.value} disabled={!!item.disabledReason}>
{item.icon}
<span className="ml-2">{item.label}</span>
<TabsTrigger value={item.value} disabled={!!item.disabledReason} asChild>
<span>
{item.icon}
<span className="ml-2">{item.label}</span>
</span>
</TabsTrigger>
</TooltipTrigger>
{item.disabledReason && (