Elgato_dark/console
1
0
Fork 0
mirror of https://github.com/graphql-hive/console synced 2026-04-21 14:37:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix(js-sdk): shutdown circuit breaker during client disposal (#7297)

Browse source
This commit is contained in:
Arda TANRIKULU 2025-11-21 02:45:32 +03:00 committed by GitHub
parent ac592d1d53
commit 64c8368c4b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 14 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/great-boxes-buy.md Normal file
View file

@ -0,0 +1,5 @@
---
'@graphql-hive/core': patch
---
Shutdown Circuit Breaker properly while disposing Hive Client

13
packages/libraries/core/src/client/agent.ts
View file

@ -253,22 +253,25 @@ export function createAgent<TEvent>(
skipSchedule: true,
throwOnError: false,
});
circuitBreaker.shutdown();
}
if (options.circuitBreaker) {
circuitBreaker = new CircuitBreaker(sendHTTPCall, {
const circuitBreakerInstance = new CircuitBreaker(sendHTTPCall, {
...options.circuitBreaker,
timeout: false,
autoRenewAbortController: true,
});
circuitBreaker = circuitBreakerInstance;
(circuitBreaker as any).on('open', () =>
circuitBreakerInstance.on('open', () =>
breakerLogger.error('circuit opened - backend seems unreachable.'),
);
(circuitBreaker as any).on('halfOpen', () =>
circuitBreakerInstance.on('halfOpen', () =>
breakerLogger.info('circuit half open - testing backend connectivity'),
);
(circuitBreaker as any).on('close', () =>
circuitBreakerInstance.on('close', () =>
breakerLogger.info('circuit closed - backend recovered '),
);
} else {
@ -277,6 +280,7 @@ export function createAgent<TEvent>(
return undefined;
},
fire: sendHTTPCall,
shutdown() {},
};
}
@ -303,4 +307,5 @@ export function createAgent<TEvent>(
type CircuitBreakerInterface<TI extends unknown[] = unknown[], TR = unknown> = {
fire(...args: TI): TR;
getSignal(): AbortSignal | undefined;
shutdown(): void;
};