Elgato_dark/console
1
0
Fork 0
mirror of https://github.com/graphql-hive/console synced 2026-05-23 09:08:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Improve ClickHouse error logging (#55)

Browse source
This commit is contained in:
Dotan Simha 2022-05-24 11:51:36 +03:00 committed by GitHub
parent a7db1fcf2d
commit 598cd09d03
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
packages/services/api/src/modules/operations/providers/clickhouse-client.ts
View file

@ -15,11 +15,7 @@ export interface QueryResponse<T> {
};
}
export type RowOf<T extends QueryResponse<any>> = T extends QueryResponse<
infer R
>
? R
: never;
export type RowOf<T extends QueryResponse<any>> = T extends QueryResponse<infer R> ? R : never;
const agentConfig: Agent.HttpOptions = {
// Keep sockets around in a pool to be used by other requests in the future
@ -68,11 +64,9 @@ export class ClickHouse {
op: queryId,
});
const startedAt = Date.now();
const endpoint = `${this.config.protocol ?? 'https'}://${
this.config.host
}:${this.config.port}`;
const endpoint = `${this.config.protocol ?? 'https'}://${this.config.host}:${this.config.port}`;
this.logger.debug(`Execution ClickHouse Query: %s`, query);
this.logger.debug(`Executing ClickHouse Query: %s`, query);
const response = await this.httpClient
.post<QueryResponse<T>>(
@ -99,7 +93,7 @@ export class ClickHouse {
request: timeout,
},
retry: {
calculateDelay: (info) => {
calculateDelay: info => {
if (info.attemptCount >= 6) {
// After 5 retries, stop.
return 0;
@ -107,6 +101,8 @@ export class ClickHouse {
const delayBy = info.attemptCount * 250;
this.logger.error(`Failed to run ClickHouse query, error is: `, info.error);
this.logger.debug(
`Retry (delay=%s, attempt=%s, reason=%s, queryId=%s)`,
delayBy,
@ -139,13 +135,7 @@ export class ClickHouse {
return response;
}
translateWindow({
value,
unit,
}: {
value: number;
unit: 'd' | 'h' | 'm';
}): string {
translateWindow({ value, unit }: { value: number; unit: 'd' | 'h' | 'm' }): string {
const unitMap = {
d: 'DAY',
h: 'HOUR',