Elgato_dark/console
1
0
Fork 0
mirror of https://github.com/graphql-hive/console synced 2026-05-23 17:18:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Add Content-Type: application/json in /schema and /metadata endpoints in CDN (#417)

Browse source 
Closes #368
This commit is contained in:
Kamil Kisiela 2022-09-29 15:01:41 +02:00 committed by GitHub
parent 0a6f5ffb66
commit 3b63506329
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 42 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/services/cdn-worker/src/handler.ts
View file

@ -20,7 +20,13 @@ const artifactTypesHandlers = {
/**
* Returns SchemaArtifact or SchemaArtifact[], same way as it's stored in the storage
*/
schema: (targetId: string, artifactType: string, rawValue: string) => new Response(rawValue, { status: 200 }),
schema: (targetId: string, artifactType: string, rawValue: string) =>
new Response(rawValue, {
status: 200,
headers: {
'Content-Type': 'application/json',
},
}),
/**
* Returns Federation Supergraph, we store it as-is.
*/

36
packages/services/cdn-worker/tests/cdn.spec.ts
View file

@ -35,6 +35,40 @@ describe('CDN Worker', () => {
afterEach(clearWorkerEnv);
test('in /schema and /metadata the response should contain content-type: application/json header', async () => {
const SECRET = '123456';
const targetId = 'fake-target-id';
const map = new Map();
map.set(`target:${targetId}:schema`, JSON.stringify({ sdl: `type Query { dummy: String }` }));
mockWorkerEnv({
HIVE_DATA: map,
KEY_DATA: SECRET,
});
const token = createToken(SECRET, targetId);
const schemaRequest = new Request(`https://fake-worker.com/${targetId}/schema`, {
headers: {
'x-hive-cdn-key': token,
},
});
const schemaResponse = await handleRequest(schemaRequest, KeyValidators.Bcrypt);
expect(schemaResponse.status).toBe(200);
expect(schemaResponse.headers.get('content-type')).toBe('application/json');
const metadataRequest = new Request(`https://fake-worker.com/${targetId}/schema`, {
headers: {
'x-hive-cdn-key': token,
},
});
const metadataResponse = await handleRequest(metadataRequest, KeyValidators.Bcrypt);
expect(metadataResponse.status).toBe(200);
expect(metadataResponse.headers.get('content-type')).toBe('application/json');
});
describe('Basic parsing errors', () => {
it('Should throw when target id is missing', async () => {
mockWorkerEnv({
@ -117,7 +151,7 @@ describe('CDN Worker', () => {
expect(response.status).toBe(200);
});
it('Should throw on missmatch of token target and actual target', async () => {
it('Should throw on mismatch of token target and actual target', async () => {
const SECRET = '123456';
mockWorkerEnv({